Skip to content

Declare location hardware optional via uses-feature - #29

Merged
T0liver merged 1 commit into
mainfrom
c-gps-optional-uses-feature-439c
Nov 21, 2026
Merged

T0liver merged 1 commit into
mainfrom
c-gps-optional-uses-feature-439c

Conversation

@T0liver

@T0liver T0liver commented Nov 21, 2026

Copy link
Copy Markdown
Owner

Summary

android:required="false" on <uses-permission> has no effect, so location was still implied as a required hardware feature for Play filtering.

  • Remove invalid android:required from location (and INTERNET) permission tags.
  • Add explicit optional <uses-feature> entries for android.hardware.location, .gps, and .network.

Location code already fails gracefully when no provider is available (LocationRepositoryImpl returns Result errors); no code changes needed.

Verification

  • ./gradlew assembleDebug — BUILD SUCCESSFUL
  • aapt2 dump badging app-debug.apk shows:
    • uses-feature-not-required: android.hardware.location (and .gps, .network)
    • No uses-implied-feature for location

Fixes #21

Open in Web Open in Cursor 

Remove invalid android:required on uses-permission entries (no effect).
Add optional uses-feature declarations for location, GPS, and network
so Play does not treat GPS as mandatory for install.

Fixes #21

Co-authored-by: T0liver <T0liver@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Test Results

1 tests  ±0   1 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 72216bc. ± Comparison against base commit c865cc7.

@T0liver
T0liver merged commit bd986ae into main Nov 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Automated test] "GPS optional" change is ineffective; declare location hardware optional via uses-feature

2 participants