Repository navigation
Fix Stats Hungarian strings and issue #22 cosmetic items - #30
Merged
Merged
Conversation
Move Stats period and heatmap weekday labels into resources with Hungarian translations, fix plurals/rounding/theme dialog, and sanitize common network errors. Co-authored-by: T0liver <T0liver@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22
Checklist (issue #22)
Missing Hungarian strings
stats_period_*+StatPeriodSelector)heatmap_weekday_labelsstring-array)Minor cosmetic / UX
★in text (star icon only)tasting_count/day_countplurals for wine detail & stats streakkotlin.math.round) instead of truncatedWineDetailViewModelupdateswineon save)·when country is emptyWineYearsin list/detail VMsLeft open
WineFormSheet).Build
./gradlew assembleDebug testDebugUnitTest lintDebug— BUILD SUCCESSFULNotes
New strings appended under
<!-- Stats -->instrings.xml/values-hu/strings.xmlto reduce merge friction with PR #27.