Skip to content

Fix Stats Hungarian strings and issue #22 cosmetic items - #30

Merged
T0liver merged 1 commit into
mainfrom
c-fix-issue-22-stats-i18n-ba2f
Nov 21, 2026
Merged

T0liver merged 1 commit into
mainfrom
c-fix-issue-22-stats-i18n-ba2f

Conversation

@T0liver

@T0liver T0liver commented Nov 21, 2026

Copy link
Copy Markdown
Owner

Fixes #22

Checklist (issue #22)

Missing Hungarian strings

  • Stats period chips localized (stats_period_* + StatPeriodSelector)
  • Heatmap weekday letters localized (heatmap_weekday_labels string-array)

Minor cosmetic / UX

  • Cellar rating badge: removed duplicate ★ in text (star icon only)
  • Plurals: tasting_count / day_count plurals for wine detail & stats streak
  • Theme dialog title uses Theme; full rows are tappable
  • Stats averages rounded (kotlin.math.round) instead of truncated
  • Wine detail refreshes name after edit (WineDetailViewModel updates wine on save)
  • User-friendly messages for offline geocode host errors & cleartext catalog URLs
  • Wine card meta line omits trailing · when country is empty
  • Invalid wine years rejected on save (1900…current+1) via WineYears in list/detail VMs

Left open

Build

./gradlew assembleDebug testDebugUnitTest lintDebug — BUILD SUCCESSFUL

Notes

New strings appended under <!-- Stats --> in strings.xml / values-hu/strings.xml to reduce merge friction with PR #27.

Open in Web Open in Cursor 

Move Stats period and heatmap weekday labels into resources with Hungarian
translations, fix plurals/rounding/theme dialog, and sanitize common network errors.

Co-authored-by: T0liver <T0liver@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Test Results

1 tests  ±0   1 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 4afabdd. ± Comparison against base commit c865cc7.

@T0liver
T0liver merged commit 0a75d36 into main Nov 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Automated test] Missing Hungarian strings in Stats + minor cosmetic issues

2 participants