Repository navigation
Say when the one-county-per-member limit blocks a county - #219
Conversation
A realm can hold at most one county per member, but the County View only showed "Unavailable" next to a full province count, so players thought they could claim it. Unclaimed counties and the "Create a new County" button now show "County limit reached: held/members (one per member)" and ask for more members. The create button no longer says "Click to create" at the limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Shared limit check and creation guard src/main/java/net/tfminecraft/simplefactions/tiers/Title.java, src/main/java/net/tfminecraft/simplefactions/managers/inventory/TierTitleView.java |
Title adds static and instance county-limit checks. Title creation and county formation use the check to stop when the limit is reached. |
Inventory availability and limit message src/main/java/net/tfminecraft/simplefactions/managers/inventory/TierTitleCreator.java, src/test/java/net/tfminecraft/simplefactions/managers/inventory/ArmyMenusCoverageTest.java |
Unavailable county titles and new-title items display the county-title count against the member count. The test checks item availability and limit messages before and after adding a member. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Feature
Suggested reviewers: ryanbarlow97
Merge Risk: 
e8134
-
The change explains county limits without changing the rule. No actionable merge-blocking issue remains after normal checks.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
github-actions
Bot
added
the
size:S
|
@coderabbitai review |
|
Dev bot test (TFMCDev01, 10-30 19:37 UTC): a 1-member realm holding COUNTY_8 sees the limit lines on Orseime and on Create a new County; after a second member joins both are gone. 7/7 checks pass. |
✅ Action performed
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Why
A player owned 5/5 provinces of Thrymsdal and the County View said only "Unavailable". The hidden reason was the rule that a realm holds at most one county per member, and their realm already held as many counties as it has members. Nothing in the menu said so.
What changes
County limit reached: 1/1 (one per member)(counties held / members)Recruit more members to hold another county.Title.countyLimitReached, used by the claim check, the create-button click and both menu items. The rule itself is unchanged.Counties owned by another realm and counties the realm already holds don't get the lines.
Tests
ArmyMenusCoverageTest.countyButtonsSayWhenTheOneCountyPerMemberLimitBlocksThem: at 1 member / 1 county the lines appear on an unclaimed county and on the create button; with a second member they're gone and the county is claimable.main(directory fsyncAccessDeniedException); Linux CI is the real check.🤖 Generated with Claude Code