Maintenance/adobe edge/dependency - #464
Conversation
🦋 Changeset detectedLatest commit: 881483b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| '@theoplayer/react-native-analytics-adobe-edge': patch | ||
| --- | ||
|
|
||
| Upgraded @adobe/alloy dependency to v2.35.0. |
There was a problem hiding this comment.
🔍 Alloy 2.35 runtime behaviour not verifiable in this checkout
AGENTS.md advises verifying third-party SDK behaviour against the pinned dependency in node_modules/@adobe/alloy/dist/alloy.js rather than from memory. node_modules is not installed in this checkout, so the only assurance that the connector's usage of createInstance and the media tracker API (adobe-edge/src/internal/web/AdobeEdgeHandler.ts) is unchanged in 2.35.0 comes from the mocked jest suite, which does not exercise the real SDK. Worth confirming the package-level checks (cd adobe-edge && npm test, npm run typescript) were run against the upgraded dependency, since CI runs neither.
Was this helpful? React with 👍 or 👎 to provide feedback.
Review — LGTMScope is exactly right: Verified locally (on the branch, after
API compatibility with what the connector actually uses ( The one behavioural thing worth a mention in a changelog sense: 2.35.0 adds Lockfile side effects (all benign, all upstream):
Supply-chain check: Nothing blocking. Only remaining gate is the pending Android/iOS/tvOS e2e jobs — which don't exercise the web alloy path anyway. |
Upgraded @adobe/alloy dependency to v2.35.0.