Repository navigation
site: publish an OpenSearch description so browsers can search the catalog (#241) - #242
Closed
riteshyadav33302111-cell wants to merge 1 commit into
Conversation
2 tasks
TMHSDigital
added a commit
that referenced
this pull request
Nov 6, 2026
The fixes these pull requests made had already landed on main, so their branches conflict; these are the parts main did not have: - data.schema.json: list items must be non-empty strings (minLength 1), from #244. schema-check.mjs gains minLength (by character) so the build's own schema check can enforce it. - checks.test.mjs: a preview URL with an unclosed IPv6 bracket, and one carrying credentials, are refused rather than thrown, from #243. - site/README.md: a paragraph on opensearch.xml, from #242. Co-authored-by: harshkanhat <kanhatharsh@gmail.com> Co-authored-by: bfs2021 <101915083+bfs2021@users.noreply.github.com> Co-authored-by: Ritesh Yadav <riteshyadav33302111@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LpkeXQPaUhxjgqdqnk6BrJ
Owner
|
Thank you for this, and for the thorough tests. #241 was fixed on Your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #241
Summary
openSearchXmlinsite/lib/exports.mjsexporting an OpenSearch 1.1 description document containing<ShortName>,<Description>,<InputEncoding>,<Image>(pointing tofavicon.svg), and<Url>template (?q={searchTerms}).site/build.mjsto generateopensearch.xmlduring build and output it tosite/dist/opensearch.xml.<link rel="search" type="application/opensearchdescription+xml" title="Free Game Dev Assets" href="opensearch.xml" />tosite/public/index.html.site/README.mddocumenting the new export.site/lib/lib.test.mjsverifying document tags, XML escaping, trailing slash normalization, and homepage link presence.All tests (
npm test) and validation checks (npm run check) pass cleanly.