Skip to content

Refuse unparseable https preview URLs instead of crashing validate #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bfs2021 wants to merge 1 commit into from
Closed

Refuse unparseable https preview URLs instead of crashing validate #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions site/checks.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,8 +1063,16 @@ export function checkPreviewField(rel, meta) {
if (meta.preview === undefined || meta.preview === null || meta.preview === "") return [];
const v = String(meta.preview);
if (v === "none") return [];
if (/^https:\/\/\S+$/.test(v) && safeImageUrl(v) === new URL(v).href) return [];
if (/^https:\/\/\S+$/.test(v)) return [`${rel} preview must be an https:// image URL on a public host`];
if (/^https:\/\/\S+$/.test(v)) {
let href = null;
try {
href = new URL(v).href;
} catch {
href = null;
}
if (href !== null && safeImageUrl(v) === href) return [];
return [`${rel} preview must be an https:// image URL on a public host`];
}
return [`${rel} preview must be "none" or an https:// image URL`];
}

Expand Down
2 changes: 2 additions & 0 deletions site/checks.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,6 +828,8 @@ accepts("preview field: https url", checkPreviewField("ok.md", { preview: "https
rejects("preview field: http refused", checkPreviewField("bad.md", { preview: "http://a/b.png" }), 'bad.md preview must be "none" or an https:// image URL');
rejects("preview field: loopback refused", checkPreviewField("bad.md", { preview: "https://127.0.0.1/a.png" }), "bad.md preview must be an https:// image URL on a public host");
rejects("preview field: word refused", checkPreviewField("bad.md", { preview: "yes" }), 'bad.md preview must be "none" or an https:// image URL');
rejects("preview field: unparseable https url refused", checkPreviewField("bad.md", { preview: "https://[bad" }), "bad.md preview must be an https:// image URL on a public host");
rejects("preview field: userinfo refused", checkPreviewField("bad.md", { preview: "https://u:p@a.example/b.png" }), "bad.md preview must be an https:// image URL on a public host");

/* V30: line endings ------------------------------------------------------ */
accepts("V30 accepts LF-only text", checkLineEndings("ok.md", "---\nid: a\n---\n\nBody\n"));
Expand Down