Repository navigation
fix(sdk-guides): Steamworks.NET enum names, C# Workshop guide, input parity (#54) - #75
Merged
Merged
Conversation
Signed-off-by: Emilio Castejón <107069576+ect2000@users.noreply.github.com>
Signed-off-by: Emilio Castejón <107069576+ect2000@users.noreply.github.com>
Signed-off-by: Emilio Castejón <107069576+ect2000@users.noreply.github.com>
…parity, registered call results - createLobby: C# uses ELobbyType.k_ELobbyType* (Steamworks.NET keeps the native names); C++/C# register their CallResult; GDScript connects the signal and renames the shadowing connect parameter to this_connect - uploadWorkshopItem: adds the promised Steamworks.NET C# block; GDScript sets description and tags; C++ registers CreateItem and SubmitItemUpdate call results and checks the Workshop legal agreement flag - Tests for each, on top of #51's escaping Fixes #54 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # src/tools/__tests__/sdk-guides.test.ts # src/tools/uploadWorkshopItem.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54. Stacked on #51: this branch contains ect2000's #51 (unchanged) merged with current main, plus one commit for #54. Merge #51 first; this PR's diff then shrinks to the #54 commit.
Changes (#54)
steam_createLobby: C# now uses Steamworks.NET's real enum names (ELobbyType.k_ELobbyTypePublic). The oldELobbyType.Publicdid not compile. C++ and C# register their call results. GDScript connectslobby_createdand renames theconnectparameter, which shadowedObject.connect, tothis_connect.steam_uploadWorkshopItem: adds the Steamworks.NET C# block the description already promised. GDScript now sets the description and tags. C++ registers the CreateItem and SubmitItemUpdate call results and checksm_bUserNeedsToAcceptWorkshopLegalAgreement.Not done: compiling the output against the real bindings (Steamworks.NET, GodotSteam, the Steamworks SDK) in CI. The issue suggests it, but it needs those SDKs in CI. A Facepunch.Steamworks variant is also out of scope.
Tests:
npm run buildand 473 tests pass locally, including 3 new #54 tests.🤖 Generated with Claude Code