Repository navigation
perf(sidebar): put the first catalog's outline up a committed frame later - #3849
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommittedTurn.after: the frame's transaction commits, then a main-queue hop). On 50,000 MySQL tables the listing could land while the restored query tab's frame was committing, and the outline's build joined that turn: one stall of about 180 ms where each part alone is under 100. The loading state stays up until then, so no frame shows a half-built sidebar.baseline.jsonis recorded again on the Mac it names. perf(sidebar): cut connect and filter stalls on large catalogs #3842 moved the end ofsidebar-listingto after the outline's frame, and perf(connection-window): keep the restored tab out of the connected panes' frame #3846 gave the footprint a budget, so the old budgets measured something else and the footprint had none.Test plan
SidebarObjectListPresentationTests.heldCatalogReadsAsLoading,NSWindowNextFrameTests.committedTurnRunsLater.Refs #3661