Repository navigation
feat(whats-new): announce an update on Linux and stay quiet after a downgrade in every app - #3878
Merged
Merged
Conversation
Member
|
looks great |
…ach app's updates are
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
last-seen-version, compared by semver.linux/docs/releasing.md, Downgrades). Before, it said "updated to" the older version and overwrote the newer one.action-name(app.about) instead of a closure.LaunchNoticeenum with one hand-over path. Each stays on every page the window shows (picker, connecting, workspace) until dismissed, and a new notice replaces only its own kind.linux/docs/storage.mdlists the new key.CFBundleVersioninlastSeenAppBuild, the number Sparkle orders updates by, so a beta sorts below its stable. An older build shows nothing and writes nothing. A Mac that recorded only the version before carries it over once.Screenshots
The picker on the first launch after an update, from a release-profile build. Before is main, which says nothing.
What's New opens the About dialog, and its What's New row the release notes:
Test plan
application::tests::a_launch_after_a_newer_release_says_nothing_and_keeps_its_version: fails on the PR's first version.application::launch_notice::tests::only_a_launch_after_an_older_release_is_an_update: semver order, pre-releases, downgrades, an unreadable stored version.application::tests::the_first_launch_after_an_older_release_says_so_once,a_first_launch_records_the_version_and_says_nothing.about_dialog::tests::the_newest_release_has_notes_for_whats_new.ui::session_window::launch_notice::tests: What's New opens the About dialog and the notice stays read, an update and a crash on each page, a second notice replaces only its own kind, the crash notice.tablepro-storagesettings::last_seen_version_starts_empty_and_round_trips.tablepro2543 passed,tablepro-storage223 passed, lint clean.WhatsNewContentTests:olderBuildIsQuietfails on main;stableAfterBetaShowsLinkOnce,legacyVersionRecordCarriesOver.notesShowLinkForNewVersion(nownotesShowLinkForNewerBuild) andfirstLaunchHasNoLinkpinned the old version key and now check the build key. 15 passed withPreferenceKeysGuardTests.FirstRunPlanTests.olderVersionShowsNothingandOnboardingPreferencesTests.olderVersionKeepsNewerRecordedfail on main; numeric order tests beside them.