Repository navigation
feat(linux-grid): pick an enum or set cell's labels from a menu - #3880
Merged
Merged
Conversation
…picker # Conflicts: # linux/crates/app/src/ui/data_grid/row_detail/value_editor.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GtkPopoverMenubuilt from a menu model, one per grid.text_like_kinds_edit_inline_and_only_text_takes_line_breaksnow pins an enum with no labels to the text editor, since an enum with labels opens the menu.Screenshots
DuckDB table,
size ENUM('small', 'medium', 'large', 'x_large'), Return on a size cell.Test plan
ui::data_grid::edit::tests::choices(new): the marked label and a pick, labels with_and the empty label, a NUL label, Set to NULL from the menu, set members toggled down to the empty set, Set to Empty on a set, Tab into an enum cell, a value with a line break, Edit Cell from the cell menu, the keyboard back on the cell after the menu closes.tests::menus::a_closed_cell_menu_gives_the_keyboard_back_to_its_cell,row_detail::tests::an_enum_field_picks_from_its_labels,cell_editor_kind,choice_menu::tests, and intablepro-coreparse_edit_textandkind(an empty set stays the empty string, fails on main).verify.sh: lint PASS,test tablepro2549 passed,test tablepro-core845 passed.