Repository navigation
perf(sidebar): group the schema listing once per listing and draw Return as a symbol - #3889
Merged
Merged
Conversation
datlechin
enabled auto-merge (squash)
October 29, 2026 21:43
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
return. The system font has no U+21A9, so its first draw in a process loaded Lucida Grande as a fallback: 9 to 11 ms measured in a fresh process, inside the first Cmd-Shift-O.QuickSwitcherKeyHinttakes a list of glyphs instead of one string.SchemaListingMatchesMemoreused the scan only for the same search, so every keystroke grouped all 50,000 rows again and copied each one.DatabaseTreeFilter.filteredTablesdeduplicates by the fieldsTableInfo.idis built from, without escaping and joining a string for each matched row. On the Oracle fixture that string was 10 of 116 samples in a filter turn.Test plan
DatabaseTreeFilterMemoTests.listingGroupingOutlivesTheSearchchecks that a new search over the same listing keeps its rows grouped once and a new listing groups again. It fails onmain, where each search builds new rows.DatabaseTreeFilterTests.filteredTablesKeepsKindsApartchecks that a table, a view and a temporary table of one name stay apart and a repeat is dropped.returnsymbol draws in 0.3 ms once any symbol has drawn, as sidebar and toolbar icons have before Open Quickly opens.Refs #3661