Repository navigation
fix(linux-grid): keep a timestamp's time when Row Details picks its day - #3890
Merged
Merged
Conversation
…flowing on the first day
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tablepro_core::edit::temporal_partsfinds the day, clock andBCera ranges in a date or time text with chrono'sparse_and_remainder, after the commit's own year normalization (chrono_year,far_year_stand_in). It replaces the hand-written scanner in the Row Details clock, so the pickers and the commit read a value the same way.2024-02-30,12:34:99,24:00:00) keeps its place and a picker replaces it.12024-01-05 10:00:00as PostgreSQL writes it,2024-1-5 10:00or2024-01-05 10:00kept as typed by SQLite) lost its time to00:00:00; now only the day changes.Test plan
edit::temporal_partstests: loose spellings, a year past 9999 and past chrono's range, the BC era, parts out of range, text the commit refuses.row_detail::tests::a_picked_day_keeps_the_time_of_any_timestamp_the_commit_readsfails on main;a_clock_on_the_first_day_chrono_holds_takes_an_offsetpanicked on main. Every existing clock and calendar spelling test passes unchanged.verify.shtest tablepro-core edit::(46 passed),test tablepro row_detail(58 passed), lint.