Repository navigation
fix(linux-workspace): make the tab menu items work and add Close All Tabs to the tab overview - #3930
Merged
Merged
Conversation
…Tabs The tab action group sat on the AdwTabView, but the menu's popover belongs to the tab bar and the overview, siblings of the view, so every item showed as insensitive. The group now lives on the shell. The menu gains Close All Tabs and dims items that would close nothing, as on macOS.
datlechin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tabactions sat on the tab view, an ancestor of neither. They now live on the shell, above all three, as the libadwaita demo puts them on its window.Test plan
the_tab_menu_reaches_its_actions_from_the_bar_and_the_overviewreaches everytab.*action from the tab box and the tab grid that parent the menu; fails on main.the_tab_menu_dims_what_would_close_nothingcovers one tab, a middle tab and the last tab.close_all_tabs_closes_the_tabs_of_every_session,close_all_tabs_is_in_the_overview_menu_and_off_with_no_tabandclose_all_tabs_asks_before_closing_unsaved_workcover Close All Tabs.