Repository navigation
fix(linux): give menu items access keys - #3938
Merged
Merged
Conversation
…-keys # Conflicts: # linux/crates/app/src/ui/workspace/sidebar/tree_menu.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_Preferences,_Keyboard Shortcuts,_About TablePro.vi.po: renamed each msgid that is no longer used anywhere else. Where the plain string is still used, the plain entry stays and a keyed entry is added. Vietnamese keys are unique per menu, counting untranslated items, and sit on an unaccented letter as GNOME's Vietnamese catalogues do.Test plan
test_support::access_keyshelper: models GtkPopoverMenu pages (sections share a page, and a submenu page includes its title) and reports missing, doubled or shared keys.every_menu_a_ui_file_holds_gives_each_item_its_own_access_keywalks every<menu>in the UI resources. Per-module tests cover the Rust-built menus: grid, references, connection menu and each tree state, sidebar, tab and main menu with Safe Mode, history, saved queries, browse, diagram, and the editor context menu with GTK's own items. All of them fail on main.