Skip to content

fix(devtools): install Neodrag core dependency - #509

Open
rczobor wants to merge 1 commit into
TanStack:mainfrom
rczobor:feat-fix-neodrag-core-dependency
Open

fix(devtools): install Neodrag core dependency#509
rczobor wants to merge 1 commit into
TanStack:mainfrom
rczobor:feat-fix-neodrag-core-dependency

Conversation

@rczobor

@rczobor rczobor commented Aug 19, 2026

Copy link
Copy Markdown

@tanstack/devtools uses @neodrag/solid, whose sortable entry imports its required @neodrag/core peer. Consumers that disable peer auto-installation therefore receive an incomplete runtime dependency graph and fail to bundle @tanstack/react-devtools.

This adds the matching @neodrag/core@3.0.0-next.11 version as a direct runtime dependency, updates the lockfile, and adds a patch changeset.

Reproduction: https://codesandbox.io/p/devbox/starter-vite-react-forked-nqxz57

Verification:

  • nx run @tanstack/devtools:test:types
  • nx run @tanstack/devtools:test:eslint
  • nx run @tanstack/devtools:test:lib (323 tests)
  • nx run @tanstack/devtools:build
  • nx run @tanstack/devtools:test:build
  • packed @tanstack/devtools into a fresh pnpm consumer with autoInstallPeers: false; install and Vite build pass

Fixes #508

Summary by CodeRabbit

  • Bug Fixes
    • Improved Devtools installation by including a required dependency for drag-and-drop functionality.
    • Added a patch release note documenting the dependency update.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f03a3a1c-2d0f-436b-a32b-24f04b98afe0

📥 Commits

Reviewing files that changed from the base of the PR and between 2df2e04 and 7e8c0e6.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • .changeset/kind-tools-drag.md
  • packages/devtools/package.json

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The devtools package now declares @neodrag/core@3.0.0-next.11 as a runtime dependency. A patch changeset documents the dependency installation for consumers.

Changes

Neodrag Core Dependency

Layer / File(s) Summary
Dependency and release metadata
packages/devtools/package.json, .changeset/kind-tools-drag.md
@tanstack/devtools now installs @neodrag/core@3.0.0-next.11. The changeset records a patch release.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 7e8c0

The change adds the required runtime dependency and updates release metadata; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: alemtuzlak

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the dependency fix for the devtools package.
Description check ✅ Passed The description explains the change, motivation, verification steps, issue link, and changeset impact, despite omitting the template headings.
Linked Issues check ✅ Passed The PR adds the required matching @neodrag/core runtime dependency and changeset, directly addressing issue #508.
Out of Scope Changes check ✅ Passed The changes are limited to the dependency fix and its release changeset, which match issue #508.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Aug 19, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 7e8c0e6

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 3m 1s View ↗
nx run-many --targets=build --exclude=examples/... ✅ Succeeded 35s View ↗

☁️ Nx Cloud last updated this comment at 2026-08-19 17:00:51 UTC

@pkg-pr-new

pkg-pr-new Bot commented Aug 19, 2026

Copy link
Copy Markdown
More templates

@tanstack/angular-devtools

npm i https://pkg.pr.new/@tanstack/angular-devtools@509

@tanstack/devtools

npm i https://pkg.pr.new/@tanstack/devtools@509

@tanstack/devtools-a11y

npm i https://pkg.pr.new/@tanstack/devtools-a11y@509

@tanstack/devtools-bundler-core

npm i https://pkg.pr.new/@tanstack/devtools-bundler-core@509

@tanstack/devtools-client

npm i https://pkg.pr.new/@tanstack/devtools-client@509

@tanstack/devtools-rspack

npm i https://pkg.pr.new/@tanstack/devtools-rspack@509

@tanstack/devtools-ui

npm i https://pkg.pr.new/@tanstack/devtools-ui@509

@tanstack/devtools-utils

npm i https://pkg.pr.new/@tanstack/devtools-utils@509

@tanstack/devtools-vite

npm i https://pkg.pr.new/@tanstack/devtools-vite@509

@tanstack/devtools-event-bus

npm i https://pkg.pr.new/@tanstack/devtools-event-bus@509

@tanstack/devtools-event-client

npm i https://pkg.pr.new/@tanstack/devtools-event-client@509

@tanstack/preact-devtools

npm i https://pkg.pr.new/@tanstack/preact-devtools@509

@tanstack/react-devtools

npm i https://pkg.pr.new/@tanstack/react-devtools@509

@tanstack/solid-devtools

npm i https://pkg.pr.new/@tanstack/solid-devtools@509

@tanstack/svelte-devtools

npm i https://pkg.pr.new/@tanstack/svelte-devtools@509

@tanstack/vue-devtools

npm i https://pkg.pr.new/@tanstack/vue-devtools@509

commit: 7e8c0e6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@tanstack/react-devtools@0.10.10 cannot resolve @neodrag/core/sortable when autoInstallPeers is false

2 participants