fix(devtools): install Neodrag core dependency - #509
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe devtools package now declares ChangesNeodrag Core Dependency
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The change adds the required runtime dependency and updates release metadata; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 7e8c0e6
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/angular-devtools
@tanstack/devtools
@tanstack/devtools-a11y
@tanstack/devtools-bundler-core
@tanstack/devtools-client
@tanstack/devtools-rspack
@tanstack/devtools-ui
@tanstack/devtools-utils
@tanstack/devtools-vite
@tanstack/devtools-event-bus
@tanstack/devtools-event-client
@tanstack/preact-devtools
@tanstack/react-devtools
@tanstack/solid-devtools
@tanstack/svelte-devtools
@tanstack/vue-devtools
commit: |
@tanstack/devtoolsuses@neodrag/solid, whose sortable entry imports its required@neodrag/corepeer. Consumers that disable peer auto-installation therefore receive an incomplete runtime dependency graph and fail to bundle@tanstack/react-devtools.This adds the matching
@neodrag/core@3.0.0-next.11version as a direct runtime dependency, updates the lockfile, and adds a patch changeset.Reproduction: https://codesandbox.io/p/devbox/starter-vite-react-forked-nqxz57
Verification:
nx run @tanstack/devtools:test:typesnx run @tanstack/devtools:test:eslintnx run @tanstack/devtools:test:lib(323 tests)nx run @tanstack/devtools:buildnx run @tanstack/devtools:test:build@tanstack/devtoolsinto a fresh pnpm consumer withautoInstallPeers: false; install and Vite build passFixes #508
Summary by CodeRabbit