You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(react-form-start): bump devalue to ^5.9.3 - #2476
Ran pnpm test:pr locally (Windows): all react-form-start targets pass. test:docs, test:knip and @tanstack/solid-form:test:lib fail, but they fail the same way on main here, so it looks like a Windows thing rather than this change.
Fresh installs already get a fixed version, but apps with an older lockfile can stay on an affected one, so this raises the minimum. Same kind of change as #1716. The Renovate PR #2123 touches this line too but only goes to ^5.7.1, and alpha already moved to ^6.0.0 in #2397, so this is for the current release line.
No actionable comments were generated in the recent review.
Walkthrough
The devalue dependency range for @tanstack/react-form-start changes from ^5.3.2 to ^5.9.3. A Changeset requests a patch release and documents the stated advisories.
Changes: devalue dependency update
Layer / File(s)
Summary
Dependency range and release note packages/react-form-start/package.json, .changeset/react-form-start-devalue.md
The package manifest updates devalue to ^5.9.3. The Changeset requests a patch release and describes the stated advisories affecting devalue.parse.
TanStack/form#2448: Changes the serialization side of the form-state cookie flow that devalue.parse reads.
Suggested reviewers:balastrong
Merge Risk: Minimal · up to 9bd74
The dependency bump has no identified merge-blocking issue. Proceed with normal release checks.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title clearly describes the main change: raising the devalue dependency version in @tanstack/react-form-start.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The pull request description follows the required template. It explains the dependency update and security motivation, completes all checklist items, reports test results, and confirms that a changese…
Full details: Description check
Explanation
The pull request description follows the required template. It explains the dependency update and security motivation, completes all checklist items, reports test results, and confirms that a changeset was generated.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between eba4084 and 9bd744d.
Files ignored due to path filters: 1
pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 2
.changeset/react-form-start-devalue.md
packages/react-form-start/package.json
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Bumps
devalueto^5.9.3in@tanstack/react-form-start.getInternalTanStackCookiepasses the cookie value todevalue.parse, and versions below 5.6.2 are affected by two denial of service advisories inparse(GHSA-g2pg-6438-jwpf, GHSA-vw5p-8cq8-m7mv). 5.9.3 also fixes three advisories instringify/unevaland custom revivers (GHSA-j22f-vq7h-c4qm, GHSA-mcm9-63f2-9j32, GHSA-r9w8-h9r3-54w4).Ran
pnpm test:prlocally (Windows): allreact-form-starttargets pass.test:docs,test:knipand@tanstack/solid-form:test:libfail, but they fail the same way onmainhere, so it looks like a Windows thing rather than this change.Fresh installs already get a fixed version, but apps with an older lockfile can stay on an affected one, so this raises the minimum. Same kind of change as #1716. The Renovate PR #2123 touches this line too but only goes to
^5.7.1, andalphaalready moved to^6.0.0in #2397, so this is for the current release line.✅ Checklist
pnpm test:pr, or these tests do not apply to this pull request.🚀 Release Impact