fix(svelte-query-devtools): update the devtools instance when options change after mount - #11009
Open
sukvvon wants to merge 5 commits into
Open
fix(svelte-query-devtools): update the devtools instance when options change after mount#11009sukvvon wants to merge 5 commits into
sukvvon wants to merge 5 commits into
Conversation
|
View your CI Pipeline Execution ↗ for commit bc827ba
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version Preview10 package(s) bumped directly, 15 bumped as dependents. 🟨 Minor bumps
🟩 Patch bumps
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthrough
ChangesSvelte devtools reactive option forwarding
Estimated code review effort: 2 (Simple) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized change makes post-mount devtools option updates take effect and adds coverage for initial and changed values; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
size-limit report 📦
|
sukvvon
changed the title
… change after mount
sukvvon
force-pushed
the
fix/svelte-query-devtools-reactive-options
branch
from
June 30, 2026 16:29
fe47bdb to
67b8c38
Compare
Contributor
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
The
devtoolsinstance inDevtools.svelteis created asynchronously insideonMount(via a dynamicimport). Because it was declared as a plainletrather than$state, the$effects that call its setters (setPosition,setButtonPosition,setInitialIsOpen,setErrorTypes) never re-ran once the instance was created. As a result, changing those options after mount had no effect on the devtools — unlike the React and Solid adapters, where the instance is part of reactive state.Declaring
devtoolsas$statemakes those effects re-run once the instance is created, so option changes are forwarded to the devtools instance.Added tests for
Devtools.sveltecovering both the initial option values and option changes after mount being forwarded to the devtools instance (position,buttonPosition,initialIsOpen,errorTypes).✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit