Add realtime (w/ fake data) trading table example - #6561
Merged
Conversation
…nts' into codex/realtime-trading-example
…into codex/realtime-trading-example
Angular,React,Solid improvements
Contributor
|
Important Review skippedToo many files! This PR contains 774 files, which is 474 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (774)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit c202067
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version Preview2 package(s) bumped directly, 10 bumped as dependents. 🟩 Patch bumps
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
More templates
@tanstack/alpine-table
@tanstack/angular-table
@tanstack/angular-table-devtools
@tanstack/ember-table
@tanstack/lit-table
@tanstack/match-sorter-utils
@tanstack/octane-table
@tanstack/preact-table
@tanstack/preact-table-devtools
@tanstack/react-table
@tanstack/react-table-devtools
@tanstack/solid-table
@tanstack/solid-table-devtools
@tanstack/svelte-table
@tanstack/table-core
@tanstack/table-devtools
@tanstack/vue-table
@tanstack/vue-table-devtools
commit: |
- Replace `for...in` loops with `Object.keys()` for better performance and clarity. - Simplify the rendering logic by removing unnecessary checks and parameters. - Ensure consistent handling of injectors across component rendering.
…e-trading-example
riccardoperra
force-pushed
the
codex/realtime-trading-example
branch
from
August 18, 2026 15:58
f221f50 to
88d56df
Compare
…ing-example' into codex/realtime-trading-example
…table into codex/realtime-trading-example
KevinVandy
marked this pull request as ready for review
August 25, 2026 12:39
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud is proposing a fix for your failed CI:
We added PLAYWRIGHT_VITE_MODE to the process.env type declaration in the five affected vite-env.d.ts files, which fixes the TS2339 type errors. The PR introduced usage of this environment variable in startExampleServer.ts, but these examples include that file in their TypeScript compilation scope and only declared NODE_ENV in their custom process type, causing the build to fail.
Tip
✅ We verified this fix by re-running tanstack-react-table-example-virtualized-columns-experimental:test:types.
Suggested Fix changes
diff --git a/examples/react/virtualized-columns-experimental/src/vite-env.d.ts b/examples/react/virtualized-columns-experimental/src/vite-env.d.ts
index d1145797c..6fd21b4a0 100644
--- a/examples/react/virtualized-columns-experimental/src/vite-env.d.ts
+++ b/examples/react/virtualized-columns-experimental/src/vite-env.d.ts
@@ -3,5 +3,6 @@
declare const process: {
readonly env: {
readonly NODE_ENV?: string
+ readonly PLAYWRIGHT_VITE_MODE?: string
}
}
diff --git a/examples/react/virtualized-columns/src/vite-env.d.ts b/examples/react/virtualized-columns/src/vite-env.d.ts
index d1145797c..6fd21b4a0 100644
--- a/examples/react/virtualized-columns/src/vite-env.d.ts
+++ b/examples/react/virtualized-columns/src/vite-env.d.ts
@@ -3,5 +3,6 @@
declare const process: {
readonly env: {
readonly NODE_ENV?: string
+ readonly PLAYWRIGHT_VITE_MODE?: string
}
}
diff --git a/examples/react/virtualized-infinite-scrolling/src/vite-env.d.ts b/examples/react/virtualized-infinite-scrolling/src/vite-env.d.ts
index d1145797c..6fd21b4a0 100644
--- a/examples/react/virtualized-infinite-scrolling/src/vite-env.d.ts
+++ b/examples/react/virtualized-infinite-scrolling/src/vite-env.d.ts
@@ -3,5 +3,6 @@
declare const process: {
readonly env: {
readonly NODE_ENV?: string
+ readonly PLAYWRIGHT_VITE_MODE?: string
}
}
diff --git a/examples/react/virtualized-rows-experimental/src/vite-env.d.ts b/examples/react/virtualized-rows-experimental/src/vite-env.d.ts
index d1145797c..6fd21b4a0 100644
--- a/examples/react/virtualized-rows-experimental/src/vite-env.d.ts
+++ b/examples/react/virtualized-rows-experimental/src/vite-env.d.ts
@@ -3,5 +3,6 @@
declare const process: {
readonly env: {
readonly NODE_ENV?: string
+ readonly PLAYWRIGHT_VITE_MODE?: string
}
}
diff --git a/examples/react/virtualized-rows/src/vite-env.d.ts b/examples/react/virtualized-rows/src/vite-env.d.ts
index d1145797c..6fd21b4a0 100644
--- a/examples/react/virtualized-rows/src/vite-env.d.ts
+++ b/examples/react/virtualized-rows/src/vite-env.d.ts
@@ -3,5 +3,6 @@
declare const process: {
readonly env: {
readonly NODE_ENV?: string
+ readonly PLAYWRIGHT_VITE_MODE?: string
}
}
Or Apply changes locally with:
npx nx-cloud apply-locally 7OZr-CCt3
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.