Skip to content

feat: GSM Secrets - Read secret inputs through the store at launch - #475

Open
yuechao-qin wants to merge 1 commit into
gsm-t1-store-hookfrom
gsm-t2-read-at-launch
Open

yuechao-qin wants to merge 1 commit into
gsm-t1-store-hookfrom
gsm-t2-read-at-launch

Conversation

@yuechao-qin

@yuechao-qin yuechao-qin commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Stacked on #474; merge after it.

What

A launch now reads a secret input through the store that holds it: give OrchestratorService_Sql a secret_value_store, and a row whose extra_data names that store is read with the store's get. Without a store, nothing changes.

The row Orchestrator's store The task gets
plain, no storage entry any, or none the row's secret_value, as today
storage names the same store type that store what get returns
storage names a store type none, or another type nothing: the launch fails as a system error
storage names the same store type that store, and get fails nothing: the launch fails as a system error, with the store's error

The mismatch error names both stores:

Secret 'TOKEN' is kept in the 'fake' store, but this server's secret store is None; it cannot be read for this launch.

Why

With #474, a row kept in a store holds only what save returned, e.g. "". Reading the column at launch would hand that placeholder to the task as if it were the value, so the launch fails instead, before anything is started.

Verification

  • tests/test_secret_value_store.py, launching a one-task pipeline through OrchestratorService_Sql with a mock launcher: a plain row reaches the task as-is with or without a store; a stored row is read through the store; no store or another store type fails the launch as a system error naming both, and nothing is launched; a failing get fails the launch the same way.
  • Mutation-checked: reading the column instead of the store, not passing the store to the orchestrator, and dropping the type check each turn tests red.
  • Full suite: 661 passed, 22 failed — the same 22 in tests/instrumentation/test_execution_tracing.py fail on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant