Repository navigation
feat: GSM Secrets - Read secret inputs through the store at launch - #475
Open
yuechao-qin wants to merge 1 commit into
Open
yuechao-qin wants to merge 1 commit into
yuechao-qin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #474; merge after it.
What
A launch now reads a secret input through the store that holds it: give
OrchestratorService_Sqlasecret_value_store, and a row whoseextra_datanames that store is read with the store'sget. Without a store, nothing changes.storageentrysecret_value, as todaystoragenames the same store typegetreturnsstoragenames a store typestoragenames the same store typegetfailsThe mismatch error names both stores:
Why
With #474, a row kept in a store holds only what
savereturned, e.g."". Reading the column at launch would hand that placeholder to the task as if it were the value, so the launch fails instead, before anything is started.Verification
tests/test_secret_value_store.py, launching a one-task pipeline throughOrchestratorService_Sqlwith a mock launcher: a plain row reaches the task as-is with or without a store; a stored row is read through the store; no store or another store type fails the launch as a system error naming both, and nothing is launched; a failinggetfails the launch the same way.tests/instrumentation/test_execution_tracing.pyfail onmaster.