Skip to content

[DO NOT MERGE] - Testing #471 (secret expires_at removal) on oasis staging - #478

Open
yuechao-qin wants to merge 2 commits into
ycq/staging-integration-secrets-namespacefrom
ycq/staging-integration-expires-at
Open

yuechao-qin wants to merge 2 commits into
ycq/staging-integration-secrets-namespacefrom
ycq/staging-integration-expires-at

Conversation

@yuechao-qin

Copy link
Copy Markdown
Collaborator

Do not merge. A test branch for oasis staging: it adds #471 (expires_at leaves the secrets API) to the commit oasis staging already pins, so staging can run it before #471 merges.

What is in it

efda100 — the commit oasis staging pins today, the head of #468 — plus one merge of ycq/secrets-hide-expires-at (#471).

Base

The base is ycq/staging-integration-secrets-namespace, #468's branch, at efda100. The diff is therefore only #471: 2 files, +12 / −9.

Checks

Check Result
merge clean; the merged diff is byte-identical to #471's own
pytest 623 passed; the 22 tests/instrumentation/test_execution_tracing.py failures also fail on master
black --check ✅

Expiry was never enforced, so the field leaves the API. The code is
commented out in place and the column stays. Clients that still send
expires_at get 200; FastAPI ignores unknown query parameters.
@yuechao-qin
yuechao-qin requested a review from Ark-kun as a code owner November 18, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant