Consider the list filter criteria in the widget configuration - #132
Open
patrickunterwegs wants to merge 1 commit into
Open
Consider the list filter criteria in the widget configuration#132patrickunterwegs wants to merge 1 commit into
patrickunterwegs wants to merge 1 commit into
Conversation
The widget so far showed every entry of the configured calendar. It now offers the same filter criteria as the list top bar (hide completed tasks, category, status), stored per widget in the Glance state and applied when the entries are loaded. To share the filtering itself instead of reimplementing it for the widget, the per-entry check moved into ListFilterCriteria.matches(), which ListState now uses as well. ListFilterRow reports back a changed ListFilterCriteria rather than a ListAction, so it can be reused outside of the list screen, and its "Hide completed tasks" label became a string resource. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RwavgpN8tKbJS7998Ecn6z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The widget so far showed every entry of the configured calendar. It now
offers the same filter criteria as the list top bar (hide completed
tasks, category, status), stored per widget in the Glance state and
applied when the entries are loaded.
To share the filtering itself instead of reimplementing it for the
widget, the per-entry check moved into ListFilterCriteria.matches(),
which ListState now uses as well. ListFilterRow reports back a changed
ListFilterCriteria rather than a ListAction, so it can be reused outside
of the list screen, and its "Hide completed tasks" label became a string
resource.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01RwavgpN8tKbJS7998Ecn6z