pdn: account for pad blockages to avoid shorting straps through pads - #11295
Open
gadfort wants to merge 5 commits into
Open
pdn: account for pad blockages to avoid shorting straps through pads#11295gadfort wants to merge 5 commits into
gadfort wants to merge 5 commits into
Conversation
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the handling of pad cell obstructions in the PDN generator. It introduces a new shape type kPadObs for pad obstructions, allowing a pad's own net to overlap with its metal rather than blocking it. It also ensures that padframe cells obstruct as soon as they are placed (even if not fixed), preventing stripes from running through them. Additionally, the review feedback suggests capturing the via pointer by value instead of by reference in a lambda capture list to avoid unnecessary indirection.
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #10222
This adds tracking of the obs for pads to avoid placing straps through the pads
Type of Change
Impact
No more stray connections into the padring. Should reduce DRC issues. Some tests were impacted because they now see the new obs
Verification
./etc/Build.sh).Related Issues
[Link issues here]