odb: add support for polygon floorplans in write_abstract_lef - #11298
Open
gadfort wants to merge 2 commits into
Open
odb: add support for polygon floorplans in write_abstract_lef#11298gadfort wants to merge 2 commits into
gadfort wants to merge 2 commits into
Conversation
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
gadfort
requested review from
osamahammad21
and removed request for
maliberty
September 1, 2026 20:10
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for non-rectangular (polygon) die areas when writing abstract LEF files. It updates the obstruction writing logic to handle polygon floorplans by writing the die area as a polygon on the OVERLAP layer and skipping system-reserved obstructions. The review feedback highlights a potential segmentation fault in lefout.cpp where db_block->getTech() is called without a null check before accessing its layers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for handling non-rectangular floorplans in write_abstract_lef, without this we write out a rectangular floorplan incorrectly and add obs for the system generated obs which is wrong.
Type of Change
Impact
No impact, except for those with non-rectangular floorplans.
Verification
./etc/Build.sh).