Repository navigation
One electron count and one solvent calc-type list (B2.8) - #144
Merged
Merged
Conversation
- config.electron_count(atoms, charge) is now the only electron count: Molecule.get_electron_count, molecule.suggest_multiplicity, xyz_input.electron_count and the SLURM resource estimate call it. The copies had already drifted once (the estimate counted Mn/Co/Ni/Mo as 0 electrons). Symbols are title-cased, so suggest_multiplicity now also counts lowercase symbols. The stdlib quantui-batch launcher keeps its port, held equal by the existing parity tests. - app_runflow's solvent-capable Calculate-tab labels are derived from batch_input.SOLVENT_CALC_TYPES plus Transition State (app-only until TS.5), instead of a second hand-written list. Same six labels as before. Contributions: - Claude (Opus 5.5): code edits, review, and conceptual discussion - Jonathan Schultz: overall vision, planning, review, and orchestration Co-authored-by: Jonathan Schultz <nccu-schultz-lab@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pieces of chemistry bookkeeping were written out in several places and had already drifted once. The SLURM resource estimate counted Mn, Co, Ni and Mo as 0 electrons.
Changes
config.electron_count(atoms, charge)is now the only electron count.Molecule.get_electron_count,molecule.suggest_multiplicity,xyz_input.electron_countand the SLURM estimate all use it. Symbols are title-cased, sosuggest_multiplicitynow also counts lowercase symbols. The standard-libraryquantui-batchlauncher keeps its own copy, which the existing parity tests hold equal.SOLVENT_CALC_TYPES, plus Transition State. TS runs only in the app until it is added to SLURM, so it is the one app-only entry. This replaces a second hand-written list; the result is the same six calc types.Testing
pytest -m "not network": 3817 passed, 19 skipped, 0 failed.Authorship