Add type hints to pancake_sort function - #15122
Closed
villenaderic wants to merge 2 commits into
Closed
Conversation
cclauss
reviewed
Aug 30, 2026
|
|
||
|
|
||
| def pancake_sort(arr): | ||
| def pancake_sort(arr: list[int]) -> list[int]: |
Member
There was a problem hiding this comment.
Would arr="Python" fail?!? arr=[1.5, 1.3, 1.0]
Author
There was a problem hiding this comment.
Good catch floats should be supported since the docstring says "comparable items," not just ints. I have updated it to use a generic type parameter (def pancake_sort[T: (int, float)](arr: list[T]) -> list[T]) so it correctly supports both, and mypy/ruff both pass now.
Member
There was a problem hiding this comment.
Perhaps https://docs.python.org/3/library/collections.abc.html#collections.abc.Hashable is the right type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Added type hints to the
pancake_sortfunction's parameter and return value, as requested in the linked issue.Fixes #14737
Checklist: