ci(devcontainer): Debian 13 Trixie + Python 3.14, Ruff settings, drop .vscode (keeper-safe .json-only) - #15161
Closed
priya-sundaram-dev wants to merge 1 commit into
Closed
Conversation
… .vscode Bumps the base image to 3.14-trixie purely via devcontainer.json's build.args.VARIANT (the Dockerfile's ARG reads it), so the Dockerfile itself is untouched and keeps installing requirements + pipx pre-commit/ruff. - VARIANT 3.13-bookworm -> 3.14-trixie (Debian 13, latest stable CPython). - Replace removed python.linting.*/blackPath settings with Ruff format-on-save + fixAll/organizeImports (matches pre-commit and CI); add the Ruff extension. - Delete .vscode/settings.json: pre-commit/Ruff cover this now. Keeps the change to .json files only.
Closing this pull request as invalid@priya-sundaram-dev, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines. If you're facing any problem on how to mark a checkbox, please read the following instructions:
NOTE: Only |
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #15160, which
algorithms-keeperkept auto-closing because it edited the extension-less.devcontainer/Dockerfile(the keeper'sACCEPTED_EXTENSIONSallow-list has no entry forDockerfile, so reopening re-triggers the close — that's why the reopen at 10:50 didn't stick).This version touches
.jsonfiles only, so the keeper accepts it, while delivering the same outcome:build.args.VARIANT3.13-bookworm->3.14-trixie. The base image is selected entirely fromdevcontainer.json— the Dockerfile'sARG VARIANTreads it — so the Dockerfile is left untouched and keeps installingrequirements.txt+ pipxpre-commit/ruff.python.linting.*/python.formatting.blackPathkeys were removed by the Python extension long ago. Replaced with RuffformatOnSave+source.fixAll/source.organizeImports, matching pre-commit and CI. Added thecharliermarsh.ruffextension..vscode/deleted (per your preference on priya-sundaram-dev as a maintainer? #15081): the sole file only muted a PR-branch notification; pre-commit/Ruff cover the rest.Notes for the open questions on #15081:
3-trixietag on themcr.microsoft.com/vscode/devcontainers/pythonpath, soVARIANTmust name the minor version; bump it when a new stable ships. (I added a comment saying so.)tvariants, and devcontainer build args can't read.python-version, so 3.14t can't be selected via the tag alone — it would need a Dockerfile/uv change, which the keeper blocks from me. Happy to do that as a maintainer-merged follow-up.Supersedes #15160.