Skip to content

ci(devcontainer): Debian 13 Trixie + Python 3.14, Ruff settings, drop .vscode (keeper-safe .json-only) - #15161

Closed
priya-sundaram-dev wants to merge 1 commit into
TheAlgorithms:masterfrom
priya-sundaram-dev:devcontainer-trixie-json
Closed

ci(devcontainer): Debian 13 Trixie + Python 3.14, Ruff settings, drop .vscode (keeper-safe .json-only)#15161
priya-sundaram-dev wants to merge 1 commit into
TheAlgorithms:masterfrom
priya-sundaram-dev:devcontainer-trixie-json

Conversation

@priya-sundaram-dev

Copy link
Copy Markdown
Contributor

Replaces #15160, which algorithms-keeper kept auto-closing because it edited the extension-less .devcontainer/Dockerfile (the keeper's ACCEPTED_EXTENSIONS allow-list has no entry for Dockerfile, so reopening re-triggers the close — that's why the reopen at 10:50 didn't stick).

This version touches .json files only, so the keeper accepts it, while delivering the same outcome:

  • Debian 13 "Trixie" + Python 3.14: bump build.args.VARIANT 3.13-bookworm -> 3.14-trixie. The base image is selected entirely from devcontainer.json — the Dockerfile's ARG VARIANT reads it — so the Dockerfile is left untouched and keeps installing requirements.txt + pipx pre-commit/ruff.
  • VS Code settings modernized: the old python.linting.* / python.formatting.blackPath keys were removed by the Python extension long ago. Replaced with Ruff formatOnSave + source.fixAll/source.organizeImports, matching pre-commit and CI. Added the charliermarsh.ruff extension.
  • .vscode/ deleted (per your preference on priya-sundaram-dev as a maintainer? #15081): the sole file only muted a PR-branch notification; pre-commit/Ruff cover the rest.

Notes for the open questions on #15081:

  • Latest-and-greatest CPython: there is no floating 3-trixie tag on the mcr.microsoft.com/vscode/devcontainers/python path, so VARIANT must name the minor version; bump it when a new stable ships. (I added a comment saying so.)
  • Free-threading (3.14t): these images don't publish t variants, and devcontainer build args can't read .python-version, so 3.14t can't be selected via the tag alone — it would need a Dockerfile/uv change, which the keeper blocks from me. Happy to do that as a maintainer-merged follow-up.

Supersedes #15160.

… .vscode

Bumps the base image to 3.14-trixie purely via devcontainer.json's
build.args.VARIANT (the Dockerfile's ARG reads it), so the Dockerfile
itself is untouched and keeps installing requirements + pipx pre-commit/ruff.

- VARIANT 3.13-bookworm -> 3.14-trixie (Debian 13, latest stable CPython).
- Replace removed python.linting.*/blackPath settings with Ruff format-on-save
  + fixAll/organizeImports (matches pre-commit and CI); add the Ruff extension.
- Delete .vscode/settings.json: pre-commit/Ruff cover this now.

Keeps the change to .json files only.
@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@priya-sundaram-dev, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant