[thedancingdeveloper]

Pushed by a worker; review follows.

🤖 Generated with Claude Code

[thedancingdeveloper]

Read-only review of 39921d0. Verdict: clean, with no blockers.

Verified locally at 39921d0: ng build (development) passed and ng test passed 35 files / 332 tests. The frontend has no lint npm script.

Correctness

• Every replaced literal in app.ts and in the Settings > General/Appearance section maps to an en.ts value that is byte-identical, including + Upload NZB, Pause for…, Add a server → and the bullet prefixes. No UI string regressed.
• The documentTitle specs in app.spec.ts are unchanged and still pass through the translateEn default, so tab titles are covered against regression.
• The title effect reads i18n.t, which reads the locale signal, so the title updates when the locale changes. The pipe is pure: false and reads the signal, so templates re-render.
• strictTemplates is on, so a typo in a key passed to the t pipe fails to compile. This includes the ternary case (paused() ? 'status.paused' : 'status.live') | t.

Non-blocking nits

1. private i18n: I18nService = new I18nService() in the App and SettingsViewComponent constructors. Angular DI ignores the default, but specs that construct the component by hand get a second, non-root instance. The pipe then injects the root instance while this.i18n is the local one. It is harmless with a single locale, but it would hide desync bugs once a second locale ships. Prefer inject(I18nService), or pass the instance explicitly in the specs.
2. usedKeys in i18n.spec.ts only sees a literal directly followed by | t, or t('…'). It misses ternaries and keys held in maps such as PAGE_TITLES. The compiler covers these today, so the gap is fine, but the test name overstates its reach.
3. A few strings in the same templates are still hardcoded: placeholder="MB/s", placeholder="min", pauseTimerOptions labels, the speed preset labels, and the other Settings panels. This is expected for groundwork; consider listing them as follow-ups.
4. I18nService writes document.documentElement.lang in its constructor. That is fine in the browser, but it would break SSR or prerender if either is ever added.

🤖 Generated with Claude Code