Skip to content

bugfix(dx8): Render the scene into an A8R8G8B8 target when the fullscreen back buffer uses the display format #3657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coconutbird wants to merge 4 commits into
base: main
Choose a base branch
from
+316 −7
Open

bugfix(dx8): Render the scene into an A8R8G8B8 target when the fullscreen back buffer uses the display format #3657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94a12ec
bugfix(dx8): Use the display format for the fullscreen back buffer wh…
coconutbird Nov 5, 2026
e470382
bugfix(dx8): Render the scene into an A8R8G8B8 target when the fullsc…
coconutbird Nov 5, 2026
f492321
bugfix(dx8): Keep the depth buffer bound when the scene alpha target …
coconutbird Nov 5, 2026
f1df119
bugfix(dx8): Keep the back buffer format when no depth buffer format …
coconutbird Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DProfilerFrameCapture.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ void W3DProfilerFrameCapture::Capture(UnsignedInt displayWidth, UnsignedInt disp
return;
}

// get the backbuffer
SurfaceClass *backBuffer = DX8Wrapper::_Get_DX8_Back_Buffer();
// get the surface the scene is rendered into
SurfaceClass *backBuffer = DX8Wrapper::_Get_DX8_Scene_Surface();
if (!backBuffer)
{
REF_PTR_RELEASE(surfaceClass);
Expand Down
6 changes: 4 additions & 2 deletions Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DSmudge.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ void W3DSmudgeManager::ReAcquireResources()
{
ReleaseResources();

SurfaceClass *surface=DX8Wrapper::_Get_DX8_Back_Buffer();
// TheSuperHackers @bugfix coconutbird 05/11/2026 Match the surface the scene is rendered into, which is not always the back buffer.

@bobtista bobtista Nov 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two aren't retail bugs. Reading the back buffer was right until this PR added the scene target. I'd drop both comments, since _Get_DX8_Scene_Surface explains itself. If you keep one, maybe make it @info.

SurfaceClass *surface=DX8Wrapper::_Get_DX8_Scene_Surface();
SurfaceClass::SurfaceDescription surface_desc;

surface->Get_Description(surface_desc);
Expand Down Expand Up @@ -323,7 +324,8 @@ void W3DSmudgeManager::render(RenderInfoClass &rinfo)
return;
}

SurfaceClass *backBuffer = DX8Wrapper::_Get_DX8_Back_Buffer();
// TheSuperHackers @bugfix coconutbird 05/11/2026 Copy from the surface the scene is rendered into, which is not always the back buffer.
SurfaceClass *backBuffer = DX8Wrapper::_Get_DX8_Scene_Surface();

if (!backBuffer)
return;
Expand Down
Loading
Loading