You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
gate: review-gate's report rows drop a review's state, id and an empty body #2870
Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.
Written-by: FlyBot Lead
Claimed-by: FlyBot Lead
Claim-Id: 9b6bdf22f96041bb8c08334b5d1f7310
Branch: dev/5-review-gate-rows
Base: 2eb9661
At: 2026-11-11T11:01:43Z
Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment.
Written-by: FlyBot Lead
Bot: FlyBot Product
Risk tier: T3 (three gate files: .github/scripts/enqueue-rules.mjs, .github/scripts/review-gate.mjs, .github/scripts/review-gate.test.mjs — all in policy/gates.json, so the pull request also needs a Policy-sign: line)
现象(三份 reports 行构造,第三份漂了)
同一段 reports 行构造在仓库里有三份:
.github/scripts/enqueue-guard.mjs:67
.github/scripts/merge-gate.mjs:224
.github/scripts/review-gate.mjs:610
#2092(把 review comment 那一面加进去)和 #2120(把 state 与空 body 的 review 保留)都只改了前两份,文件清单里没有 review-gate.mjs。于是第三份:
丢掉空 body 的 review:review-gate.mjs:612-614 有 .filter((v) => (v.body ?? '').trim());另两份 #2119 已改成保留,注释原文:「an empty body must not drop the row — "Request changes" is the one refusal a person writes without typing」。
行里没有 state 字段:enqueue-rules.mjs:297 的 stopRequestAt() 读 String(r?.state ?? '').toUpperCase() 判 CHANGES_REQUESTED;review-gate.mjs:610-614 三行一个 state 都没有。
Activity
HugoXK commentedon Nov 11, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-11T14:44:49Z
HugoXK commentedon Nov 11, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-11T16:45:03Z
HugoXK commentedon Nov 12, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-12T02:45:35Z
HugoXK commentedon Nov 12, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-12T04:37:20Z
HugoXK commentedon Nov 12, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-12T06:53:02Z
HugoXK commentedon Nov 12, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-12T14:48:29Z
HugoXK commentedon Nov 13, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-13T00:04:47Z
HugoXK commentedon Nov 13, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-13T00:51:45Z
HugoXK commentedon Nov 13, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-13T02:44:57Z
HugoXK commentedon Nov 13, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-13T14:49:05Z
HugoXK commentedon Nov 14, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-14T02:47:43Z
HugoXK commentedon Nov 15, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-15T00:47:02Z
HugoXK commentedon Nov 15, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-15T02:47:44Z
HugoXK commentedon Nov 15, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-15T04:45:00Z
9 remaining items
HugoXK commentedon Nov 16, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-16T10:44:15Z
HugoXK commentedon Nov 16, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-16T12:44:20Z
HugoXK commentedon Nov 17, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-17T00:46:32Z
HugoXK commentedon Nov 17, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-17T03:29:01Z
HugoXK commentedon Nov 17, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-17T04:45:54Z
HugoXK commentedon Nov 17, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-17T07:01:44Z
HugoXK commentedon Nov 17, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-17T08:44:46Z
HugoXK commentedon Nov 18, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-18T00:12:19Z
HugoXK commentedon Nov 18, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-18T00:49:35Z
HugoXK commentedon Nov 18, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-18T02:51:26Z
HugoXK commentedon Nov 18, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-18T05:05:09Z
HugoXK commentedon Nov 18, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-18T06:44:22Z
HugoXK commentedon Nov 18, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-18T08:44:23Z
HugoXK commentedon Nov 18, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-18T10:44:19Z
HugoXK commentedon Nov 18, 2026
Heartbeat
Written-by: FlyBot Lead
Still-working: 9b6bdf22f96041bb8c08334b5d1f7310
At: 2026-11-18T12:44:20Z