Skip to content

project(board): a cut metrics note hides the failure reason — show the whole sentence in the note #3157

Closed

Description

@HugoXK

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.

Written-by: FlyBot Lead
Claimed-by: FlyBot Lead
Claim-Id: 21c66a9a786d4cc6824e53481c4a6e2c
Branch: dev/1-metrics-note-full
Base: ed935b3
At: 2026-11-18T02:05:21Z

What is wrong

The Project board's metrics note is truncated on screen with no way to read the rest: core/src/client/project-board.js:512-516 builds shortDetail by cutting the detail at 60 characters and appending …, and :529 renders that cut string as the bt-project-metrics-note paragraph. Nothing else on the panel carries the remainder — no tooltip, no expand control — so the actionable tail of a failure reason (… the token this Project reads with cannot list pull requests on the source repository) never reaches the window.

Reproduction (on live main ed935b304f71f1da386a73c31bb1f0e070573691)

  1. Give the Project a failed metrics read whose read-failed: detail is longer than the 60-character cut.
  2. The panel shows 指标不可用:读取 GitHub 失败(/pulls answered 403: the token… and nothing more.
  3. The failing case asserts the note carries the whole sentence:
not ok 27 - a long read-failed detail is readable in full in the note
  the note carries the whole reason
  + '指标不可用:读取 GitHub 失败(/pulls answered 403: the token…'
  - '指标不可用:读取 GitHub 失败(/pulls answered 403: the token this Project reads with cannot list pull requests on the source repository)'

Expected

The note shows the whole sentence and wraps: the 60-character cut goes away, so metricsReasonText hands the complete read-failed: detail to the sentence and the paragraph wraps inside the panel instead of widening it. The board exists to tell you what failed; a reason you cannot finish reading is not a reason.

Scope

Six files: core/src/client/project-board.js (drop shortDetail/READ_DETAIL_MAX, pass the full detail, correct the "cut short" comment), core/test/project-board-view.test.js (the case above, plus any existing assertion that pins the … cut), and the generated core/client.js, patches/ds-bot/0008-client-bundle.patch, patches/ds-bot/files/src/client/project-board.js, patches/ds-bot/files/test/project-board-view.test.js.

computedTier stays T1.

UI surface

Yes — the rendered note text and its wrapping change. The PR opens with before/after screenshots in the body: same Project board view, same viewport size, zh window, the real ProjectMetrics note with its real CSS and the 403 reason from the red-first. They are rendered by the real component in a static harness (this box has only chrome-headless-shell, no full chromium/X11), and the caption says so. A native hover tooltip is not the fix here and is not claimed.

Duplicate check

Searched open issues and PRs for metrics note, shortDetail, bt-project-metrics-note: #2985 and #2997 (closed) translated the reason code and are on main; nothing open covers the unreachable tail. No duplicate.

Activity

  1. changed the title [-]project(board): a cut metrics note makes the full failure reason unreachable — carry it in the note's title[/-] [+]project(board): a cut metrics note hides the failure reason — show the whole sentence in the note[/+] on Nov 18, 2026
  2. added a commit that references this issue on Nov 18, 2026
    a306e3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions