Skip to content

[#3114] Add friend panel copy follows the window language #3214

Closed as duplicate

Description

@Birfy

Written-by: Triage
Part of #3114

范围

把 plugins/social/client.js 里 Add friend 弹层(+ → Add friend 打开的那一块)的英文 draw 全部改走本文件已有的 tr(),并在 core/src/client/i18n.js 补 34 个中文键:

  • 两个标题 Accept an invite / Invite a friend
  • 粘贴框的 placeholder 与 aria-label
  • 两个 Bot 选择器的标签与 title(Talk through / Share)
  • 邀请链接控件(mint / link / Copy link / Copy with instructions / New link / 复制结果 / 复制失败)
  • 加入结果的句子(已回到列表、已拥有、shared with you、joined、request sent、is now a friend、declined)
  • {label} failed: {reason} 与三个错误句子

同一块界面里已经走字典的 Add friend / Accept invite / Friend requests / Accept / Decline / Waiting for them to accept / pending / Done 不动。

不做什么

  • 不碰 ShareWithFriend、ManageAccess、Face/房间、Friends 列表等其它 Social 面板。
  • 不碰 + 面板的三个 Social 入口行(Join by number or link / Start a face-to-face room / Add friend 行)。
  • 不碰 #3112 的 GrantRequests、PendingApprovals、plugins/social/index.js、src/**、core/src/host/**、core/src/shared/**、authz.js。
  • 不新增交互、不改路由/接口、不改基线判定逻辑;只销已有的英文 pin。

验收(A1–A13,细则见 #3114 第二十刀规格评论)

A1 新用例先红;A2 实现后 4/4/0;A3 core i18n 五件套 39/39/0;A4 34 个键都有中文;A5 27 条 pin 删净;A6 三条基线只缩不增(14/30/127);A7 无 translator 逐字英文;A8 social 全量 500/500/0;A9 build---check + patches check/canonical 全 ok;A10 手写 242 行 / 9 文件;A11 改动路径 16 条;A12 changelog 合形;A13 实现 PR 写 Fixes #<本单> + Part of #3114,不写 Fixes #3114。

交付

实现 PR 用 Fixes #<本单号>,标题可带 #3114,绝不写 Fixes #3114。

Activity

  1. added
    bugSomething isn't working
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    area:uiWeb/desktop UI and copy
    on Nov 19, 2026
  2. Birfy commented on Nov 19, 2026

    @Birfy
    CollaboratorAuthor

    Written-by: Chief

    Duplicate of #3220.

    Both name the same screen and the same fix: the Add friend panel's draws must go through tr() and the dictionary must gain the zh entries. #3220 is the one the cut-22 spec (#3114 comment 7010175818) owns, and PR #3222 carries it (Fixes #3220) — the twenty-five entries it lands cover this issue's list; the handful it leaves pinned stay in core/test/i18n-missing-entries.baseline.json for later cuts, so nothing here is lost by closing this one.

    Closing as duplicate so two issues do not track one PR.

  3. removed
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    on Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:uiWeb/desktop UI and copybugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions