You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Blocked on one line in cut 20's own test — needs your yes before I touch it
Written-by: Dev
Cut 22 is implemented and verified on dev/3114-add-friend-zh (tip 331119fa84abf350a510c4cddc2fe9f3c79a0eb8, base 5b32b96a5a44). Everything in spec A1/A2/A4–A13 is green; the wholeplugins/social suite is 726/727 with exactly one failure, in cut 20's test — the file the task brief says I must not edit (「上一刀的测试不在你的范围;如果它们因新键而必须同步,先停下在 #3220 说明,不要自己改」).
$ cd plugins/social && TZ=UTC DSH_HARNESS=/opt/flybot npm test
not ok 177 - \#3114 cut 20: the three baselines lose these draws
location: plugins/social/test/sharing-page-i18n.test.js:140
error: |-
+ actual - expected
[ + 14, + 23, + 111 - 16, - 27, - 132 ]
# tests 727 / # pass 726 / # fail 1
sharing-page-i18n.test.js:148 freezes the three baselines' absolute totals:
Cut 22 removes 27 pins (21 missing-entries + 4 template-draws + 2 plugins), so those totals become 16 / 23 / 111 — exactly what spec A7 asks for. No pin, and no assertion about which pins remain, is weakened: cut 20's own 27 entries are still asserted one by one above that line.
Precedent, same line, same reason: cut 21's in-flight branch (dev/3114-face-waiting-room-zh, PR #3221) already changes this line to [16, 25, 115] and its PR body calls it "the seventh handwritten file, and the reason the hand-written total is 221 lines rather than the 215 in the slice spec". Cut 22 lands on the same line from the other side.
The ask: authorize one line, +1/−1, in plugins/social/test/sharing-page-i18n.test.js — [16, 27, 132] → [16, 23, 111]. Hand-written total becomes 10 files / 244 lines (still inside T2's 250 / 12), still with 229-line spec's 9 files otherwise unchanged. If cut 21 merges first I rebase and re-run build-client → generate → check → canonical, and the line then reads whatever both cuts leave (14 / 23 / 111 after cut 21's two template pins are also gone… whichever order, the totals are recomputed, never hand-guessed).
No PR is open yet: a T2 tip cannot be gated while that one check is red, so opening one now would only park a red pull request. Everything else is ready to push — say go and the PR is up in one commit.
Follow-up on the block above: the work is now visible as a draft pull request, #3222 — dev/3114-add-friend-zh at 331119fa84abf350a510c4cddc2fe9f3c79a0eb8, base 5b32b96a5a44. Draft on purpose: a T2 tip cannot be gated while the one red check stands, so it is parked until the one-line authorisation above is given. Nothing is enqueued, no Verdict: is written by this cut, and no other file is touched.
Rebase note (2026-11-19T14:02:49Z): cut 21's merge (#3221, 6e08fd75) landed while this was being verified, so dev/3114-add-friend-zh now sits on that merge and the tip is d358dbe5cdc946c4421da07d1a79dc48bf647ed4 (was 331119fa on 5b32b96a). Draft PR #3222 moved with it.
The block is the same single line, with the numbers cut 21 left behind:
So the ask is now [16, 25, 115] → [14, 21, 94], still +1/−1, still the same file. After the rebase, everything was regenerated and re-run at the new tip: build-client → generate → check → canonical all ok; red-first on a pristine 6e08fd75 still 4/1/3 (same three messages) and 4/4/0 at the tip; core i18n 39/39/0; social.test.js 500/500/0; face-rooms + social-readonly 55/55/0; core suite 3353/3353; arch-docs OK (16 files); mojibake ok; changelog ok.
Activity
Birfy commentedon Nov 19, 2026
Claim
Written-by: Dev
Claim-Id: cbaeb74235e0ac8e6853cbc82bdc4c7f
Branch: dev/3114-add-friend-zh
Base: 5b32b96
At: 2026-11-19T13:36:28Z
Cut 22 (spec comment 7010175818): Add friend panel localized — plugins/social/client.js (AddFriend + shared inviteControls + the three result lines), 25 new zh keys in core/src/client/i18n.js, 27 baseline pins removed (21 missing-entries + 4 template-draws + 2 plugins), one new test file, one changelog fragment. Handwritten 9 files / +174−55 = 229 lines; T2 (250 lines / 12 files).
Birfy commentedon Nov 19, 2026
Blocked on one line in cut 20's own test — needs your yes before I touch it
Written-by: Dev
Cut 22 is implemented and verified on
dev/3114-add-friend-zh(tip331119fa84abf350a510c4cddc2fe9f3c79a0eb8, base5b32b96a5a44). Everything in spec A1/A2/A4–A13 is green; the wholeplugins/socialsuite is 726/727 with exactly one failure, in cut 20's test — the file the task brief says I must not edit (「上一刀的测试不在你的范围;如果它们因新键而必须同步,先停下在 #3220 说明,不要自己改」).sharing-page-i18n.test.js:148freezes the three baselines' absolute totals:Cut 22 removes 27 pins (21 missing-entries + 4 template-draws + 2 plugins), so those totals become
16 / 23 / 111— exactly what spec A7 asks for. No pin, and no assertion about which pins remain, is weakened: cut 20's own 27 entries are still asserted one by one above that line.Precedent, same line, same reason: cut 21's in-flight branch (
dev/3114-face-waiting-room-zh, PR #3221) already changes this line to[16, 25, 115]and its PR body calls it "the seventh handwritten file, and the reason the hand-written total is 221 lines rather than the 215 in the slice spec". Cut 22 lands on the same line from the other side.The ask: authorize one line,
+1/−1, inplugins/social/test/sharing-page-i18n.test.js—[16, 27, 132]→[16, 23, 111]. Hand-written total becomes 10 files / 244 lines (still inside T2's 250 / 12), still with 229-line spec's 9 files otherwise unchanged. If cut 21 merges first I rebase and re-runbuild-client→generate→check→canonical, and the line then reads whatever both cuts leave (14 / 23 / 111after cut 21's two template pins are also gone… whichever order, the totals are recomputed, never hand-guessed).No PR is open yet: a T2 tip cannot be gated while that one check is red, so opening one now would only park a red pull request. Everything else is ready to push — say go and the PR is up in one commit.
Birfy commentedon Nov 19, 2026
Follow-up on the block above: the work is now visible as a draft pull request, #3222 —
dev/3114-add-friend-zhat331119fa84abf350a510c4cddc2fe9f3c79a0eb8, base5b32b96a5a44. Draft on purpose: a T2 tip cannot be gated while the one red check stands, so it is parked until the one-line authorisation above is given. Nothing is enqueued, noVerdict:is written by this cut, and no other file is touched.Written-by: Dev
Read the Add friend panel in the window's language (#3114)
Birfy commentedon Nov 19, 2026
Rebase note (2026-11-19T14:02:49Z): cut 21's merge (
#3221,6e08fd75) landed while this was being verified, sodev/3114-add-friend-zhnow sits on that merge and the tip isd358dbe5cdc946c4421da07d1a79dc48bf647ed4(was331119faon5b32b96a). Draft PR #3222 moved with it.The block is the same single line, with the numbers cut 21 left behind:
So the ask is now
[16, 25, 115]→[14, 21, 94], still+1/−1, still the same file. After the rebase, everything was regenerated and re-run at the new tip: build-client → generate → check → canonical all ok; red-first on a pristine6e08fd75still 4/1/3 (same three messages) and 4/4/0 at the tip; core i18n 39/39/0;social.test.js500/500/0; face-rooms + social-readonly 55/55/0; core suite 3353/3353; arch-docs OK (16 files); mojibake ok; changelog ok.Written-by: Dev