Repository navigation
project(board): a cut metrics note hides the failure reason — show the whole sentence in the note - #3159
Merged
Conversation
The Project board's metrics note cut a long read-failed detail at 60 characters and appended an ellipsis, so the part of the reason that mattered could not be read anywhere on screen; a title tooltip would only hide it behind a hover a touch screen cannot perform. The note now draws the whole sentence the client already had, and the cut helper is gone. Docs-not-needed: the note's sentence, its wording and the read it reports are unchanged; only a detail it used to shorten is drawn whole, and no documented behaviour moves.
HugoXK
marked this pull request as draft
November 18, 2026 02:34
HugoXK
marked this pull request as ready for review
November 18, 2026 03:20
Contributor
Author
|
@Birfy merge request — tip
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3157
Owner: Dev-1
Written-by: Dev-1
Tier: T1
Claim-Id: 21c66a9a786d4cc6824e53481c4a6e2c
Branch: dev/1-metrics-note-full
Base: ed935b3
What changed
The Project board's metrics note cut a long
read-failed:detail at 60 characters and appended…, so the part of the reason a reader needs could not be read anywhere in the window. The note now draws the whole sentence the client already had.core/src/client/project-board.js:shortDetailandREAD_DETAIL_MAXare gone;metricsReasonTexthands the completereadFailed[1]tot('reading GitHub failed ({detail})'), and the stale "cut short" comment is corrected. Notitleis added — one source of truth, and a hover is not a reason a touch screen can read.core/test/project-board-view.test.js: the case is nowa long read-failed detail is readable in full in the note; it assertsp.bt-project-metrics-note's textContent equals the whole sentence and carries no…. The old helper that returned only the note text grew a node accessor so the test reads the paragraph itself.hostText), every other zh reason is unchanged, and no new dictionary sentence was added.Red first (clean base
ed935b30, test-only tree, two runs)Same output on both runs (
# pass 0 / # fail 1).Ran (tip
1093520f9b2fc4e012a3bea8c12d7d9fa07dba76, treebbaf4f46c563d49ca401626fd3894bbcbc77cadb)node --test core/test/project-board-view.test.js→ 37/37 pass, two consecutive runsTZ=UTC npm run verify→ exit 0,0 not ok: core 3293, plane 20, social 711, tree 149, timeline 172, workflow 538, project 147,.github+policy 686, interop 37, live-e2e 34node scripts/ds-bot-patches.mjs check→10 patches apply cleanly in orderandcore/ equals ds-bot/ + patches/ds-bot/node scripts/ds-bot-patches.mjs canonical→generate is a no-op(cd core && node scripts/build-client.mjs --check)→ cleanARCH_DOCS_BASE=ed935b304f71f1da386a73c31bb1f0e070573691 node core/scripts/check-arch-docs.mjs→arch-docs: OK (6 changed file(s))node .github/scripts/changelog.mjs check→2 fragment(s) in changelog.d/ are well formed(no new fragment: no new copy)Not run: smoke test (client-only change; no
index.jsorsrc/host/file), and the CIpackagejob's pack check / typecheck / actionlint.risk-tier: T1; basis: core/client.js=T1, core/src/client/project-board.js=T1, core/test/project-board-view.test.js=T1, patches/ds-bot/0008-client-bundle.patch=T1, patches/ds-bot/files/src/client/project-board.js=T1, patches/ds-bot/files/test/project-board-view.test.js=T1Why the 0008 patch diff is large
patches/ds-bot/0008-client-bundle.patchchanges 3,024 lines althoughcore/client.jschanges only 7: deleting the 6-lineshortDetailblock shifts the diff's alignment through a long duplicated region in the generated bundle, so the generator re-splits its hunks (largest stored hunk 11,893 lines, now 8,140).patches checkreconstructscore/client.jsbyte for byte andcanonicalreportsgenerate is a no-op, so this is generator output, not a hand edit.Screenshots — same Project board view, same viewport 1280×800, zh window
Both images are the real
ProjectBoardPane(which draws the realProjectMetrics, its real CSS and the real zh dictionary) with the same 403 reason from the red-first, rendered by a static harness: real component + real zh dictionary, static harness, no full chromium on this machine (onlychrome-headless-shell, no X11). Layout measured in the same page: the note's box and the cards' box are identical in both images (note 14px tall, cards starting 6px below), so only the sentence differs.Before — the note is cut and ends in
…:After — the note reads the whole 403 reason:
The images live on the fork's
dev/1-shots-3157branch (raw links pinned to commita53ac6a9e429161d0ed0b0e9a4e66d40ab0ea368), because the API cannot upload images and they must not move this PR's tip.Docs-not-needed: the note's sentence, its wording and the read it reports are unchanged; only a detail it used to shorten is drawn whole, and no documented behaviour moves.
Checkpoint
{
"pr": 3159,
"claim": "Dev-1",
"issue": 3157,
"summary": "The Project board's metrics note cut a long read-failed detail at 60 characters and appended an ellipsis, so the actionable tail of the failure reason could not be read anywhere. The note now draws the whole sentence the client already had, and the cut helper is gone. English windows and every other zh reason are unchanged, and no new copy was added.",
"files": [
"core/src/client/project-board.js",
"core/test/project-board-view.test.js",
"core/client.js",
"patches/ds-bot/0008-client-bundle.patch",
"patches/ds-bot/files/src/client/project-board.js",
"patches/ds-bot/files/test/project-board-view.test.js"
],
"checks": {
"ran": "TZ=UTC npm run verify",
"result": "green",
"at": "1093520f9b2fc4e012a3bea8c12d7d9fa07dba76"
},
"next": "none — ready for review"
}