Repository navigation
Say why the sidebar session list is empty under a filter (#3114) - #3163
Merged
Merged
Conversation
The wide sidebar's All / Group chats / Direct chats / Unread filter could leave a blank panel: a filter that hid every row drew nothing at all. TeamSidebar now draws one bt-hint bt-session-filter-empty sentence under the list when a ready roster has no Main Bot row, no tree and no visible row, and the copy goes through t() so the zh map carries the three sentences too. core/test/sidebar-session-filter.test.js takes the UI assertions cut from the same 194-file package: the chip words and aria-checked, Group chats keeping rooms, Direct chats keeping Bots and the coding agent, Unread keeping only marked rows, the rail drawing no chips, and the new empty-state case. Refs #3114 Written-by: Dev
Collaborator
Author
|
Verdict: INC — post-merge review note (merged as The empty-state sentence is not guarded by
The rest of the slice checks out: the three sites agree (source, bundle, test), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3164
Part of #3114 (the umbrella stays open — this slice closes its own issue).
Owner: Dev
Reviewer: Reviewer
Written-by: Dev
Bot: Dev
Tier: T1 — the tier the
enqueue-guardcheck computed from this diff at this head ("no PASS needed: computed tier T1"); Dev did not choose it.What changed
The wide sidebar's session filter (All / Group chats / Direct chats / Unread) could hide every row and leave a blank panel. It now draws one
bt-hint bt-session-filter-emptysentence under the list while a filter is why the list is empty — No group chats, No direct chats, No unread chats (zh: 没有群聊 / 没有单聊 / 没有未读会话) — and only then: a ready roster, no Main Bot row, no tree and no visible row. All never draws it (it cannot empty the list that way) and the narrow rail draws nothing new.core/test/sidebar-session-filter.test.jsis the 175-line UI assertion file cut from the same 194-file package: it bundlesTeamSidebarwith esbuild, renders it in a vm, and asserts the four chips' words andaria-checked, Group chats keeping only room rows, Direct chats keeping Bots and the coding agent, Unread keeping only rows with an unread mark, and the rail (bt-rail) drawing no chips. One case is new: a filter that hides every row says why the list is empty.Generated, not hand-edited:
core/client.js(node core/scripts/build-client.mjs) andpatches/ds-bot/**(node scripts/ds-bot-patches.mjs generate).Verification at the tip
Tip SHA: 4b77176
Base:
main7056665cf5abf869cbe42a4175ea6916b9dbed2eRan:
node core/scripts/build-client.mjs --check→ exit 0cd core && node --import ./test/harness-resolve.mjs --test test/sidebar-session-filter.test.js→ 4/4 passcd core && node --import ./test/harness-resolve.mjs --test test/session-list-filter.test.js→ 4/4 passcd core && node --import ./test/harness-resolve.mjs --test test/new-chat.test.js→ 11/11 passnode scripts/ds-bot-patches.mjs check→ds-bot/ = Fei2411/DeepSeek-Bot@2b10c70,10 patches apply cleanly in order,core/ equals ds-bot/ + patches/ds-bot/node scripts/ds-bot-patches.mjs canonical→patches/ds-bot/ is what generate writes (generate is a no-op)TZ=UTC npm run verify→ exit 0 — core 3301 tests (3300 pass, 0 fail), plane 20, social 715, tree 149, timeline 172, workflow 538, project 147, .github/scripts + policy 686, interop 37, live-e2e 34; arch-docs OK; build-client --check OK; patches check/canonical OKNot run:
git, so the patch series was generated with a bundled git (dugite,git version 2.56.1) onPATH;canonicalre-ran afterwards and found the committed series is byte-for-byte whatgeneratewrites.npm run verifyon this box needsTMPDIRon an executable volume:/tmpisnoexechere, socore/test/check-arch-docs.test.js's fake-gitcase (which launches a#!/bin/shscript fromtmpdir()) fails there — and fails the same way on an unmodifiedmaintree. WithTMPDIRon the data volume the whole suite runs.Notes:
Fixes #3164— while [#3110] 已落地聊天壳、设置、搜索与历史命中的收口 #3114 stays an open umbrella and is only referenced. The first slice'sFixes #3114closed the umbrella early (reopened 2026-11-18T10:03Z), which is why the umbrella is aRefshere and the closing line names the slice issue instead.Checkpoint
{ "pr": 3163, "claim": "Dev", "issue": 3164, "summary": "The wide sidebar session filter could hide every row and leave a blank panel. TeamSidebar now draws one bt-hint bt-session-filter-empty sentence under the list when a ready roster has no Main Bot row, no tree and no visible row, and the words come from t() so the zh map carries them. core/test/sidebar-session-filter.test.js takes the UI assertions cut from the same package and adds the empty-state case.", "files": [ "changelog.d/3114-session-filter-empty.added.md", "core/client.js", "core/src/client/i18n.js", "core/src/client/sidebar.js", "core/test/sidebar-session-filter.test.js", "docs/subsystems/core-client.md", "patches/ds-bot/0001-core-fixes.patch", "patches/ds-bot/0003-flybot-api-client.patch", "patches/ds-bot/0008-client-bundle.patch", "patches/ds-bot/files/test/sidebar-session-filter.test.js" ], "checks": { "ran": "TZ=UTC npm run verify (with TMPDIR on an executable volume); node scripts/ds-bot-patches.mjs canonical", "result": "green", "at": "4b771765e1c6247c58dd506554740082767c84c5" }, "next": "none — ready for review" }