Skip to content

History search rows: land on the hit, say what the cap hid (#3114) - #3187

Merged
Birfy merged 1 commit into
mainfrom
dev/3114-history-hit-rows
Nov 18, 2026
Merged

Birfy merged 1 commit into
mainfrom
dev/3114-history-hit-rows

Conversation

@Birfy

@Birfy Birfy commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Written-by: Dev

Fixes #3186
Part of #3114
Owner: Dev
Reviewer: Reviewer
Tier: T1

Checkpoint

{
"pr": 3187,
"claim": "Dev",
"issue": 3186,
"summary": "History search rows now say what they are and land where they point. An outline message row opens the chat at its own turn, two hits in one turn are two rows, and a hit the current part does not hold is marked Earlier part and opens the chat without a turn. A capped whole-text answer says how many matches the host left out and asks for one more word, and a Bot whose current part is a Session of its own no longer shows the same message twice.",
"files": [
"core/src/client/palette.js",
"core/src/client/index.js",
"core/src/client/i18n.js",
"core/src/client/styles.js",
"core/test/palette-preview.test.js",
"docs/subsystems/core-client.md"
],
"checks": {
"ran": "npm run verify (exit 0); palette-preview 22/22; regression 51/51; ds-bot-patches check + canonical; arch-docs; changelog check",
"result": "green",
"at": "f7179a2581350f02d28e71ef823c9139afbd0618"
},
"next": "none — ready for review (T1: green tests-ok at the tip is the gate, no PASS)"
}

Verification at the tip

Ran at f7179a2581350f02d28e71ef823c9139afbd0618 (client and host suites with DSH_HARNESS=/opt/flybot, TZ=UTC, TMPDIR=/data/flybot-tmp):

  • npm --prefix core run build && node core/scripts/build-client.mjs --check → OK, and the branch tree equals the tree built here.
  • node --import ./test/harness-resolve.mjs --test test/palette-preview.test.js → # tests 22 / # pass 22 / # fail 0.
  • Red first, both stages recorded: the 22 cases with the implementation untouched → # pass 5 / # fail 17; with the behaviour-neutral contract migration ({hits, turns} + the short-query branch + {rows, more} in searchChats) → # pass 17 / # fail 5, the five reds being B1–B5. Then 22/22.
  • Regression: client-bundle, chat-index-writers, earlier-message-actions, at-menu, empty-message-cell, i18n, i18n-missing-entries → 51/51 (2/9/6/11/3/20).
  • node scripts/ds-bot-patches.mjs check → ds-bot/ = Fei2411/DeepSeek-Bot@2b10c70, 10 patches apply cleanly in order, core/ equals ds-bot/ + patches/ds-bot/; canonical → "generate is a no-op".
  • npm --prefix core run arch-docs → arch-docs: OK (12 changed file(s)).
  • node .github/scripts/changelog.mjs check → 6 fragments well formed.
  • node .github/scripts/check-mojibake.mjs --check → ok, 0 occurrences of U+FFFD.
  • TZ=UTC TMPDIR=/data/flybot-tmp npm run verify → exit 0 (686 + 538 + 172 + 151 + 37 + 34 and the rest, # fail 0 in every suite).

Not run:

  • The smoke test (core/dev/bench.sh) — no test bench was started here. No host file is touched by this change, so nothing on the host side moved.
  • No PASS: this is a T1 client-only change; nothing is enqueued from this pull request.
  • Boundaries this change does not cover (they are the spec's §11): a hit in an older part is marked only and opens the current part at its newest view, since jumping to that part needs a host part field (T3, left to the owner); turns[chat] has a value only while the current part's outline is loaded, and until then the row behaves exactly as before; a hidden exchange turn keeps its turn because its position is in the flow, though its reply text is not drawn; more is the host's total − shown and can count rows this client does not hold; a more > 0 answer whose every row is deduped draws no group and so no note; and the same part's same turn is still one message, because telling its hits apart needs seq on the row (host side).

Keyword scan (§7)

git diff -U0 origin/main...HEAD | grep '^+' | grep -v '^+++' | grep -nE 'child_process|process\.env\.[A-Za-z_]*(TOKEN|KEY|SECRET)|DSH_HOME|\.(only|skip)\(|(eslint|oxlint)-disable|eval\(|new Function\(|untrusted-(message|file)'

→ empty output: no new line carries a gate keyword, a skipped test, or a marker word. The full §7 expression (with its URL allow-list) also printed nothing.

Files are the spec's 12: 7 handwritten (palette.js, index.js, i18n.js, styles.js, the palette test, docs/subsystems/core-client.md, the changelog fragment) and 5 generated (core/client.js, three patches, the files/ mirror), +135/−22 handwritten.

A Messages row opens its own turn; a capped whole-text answer says how many
matches the host left out; two hits in one turn are two rows; a hit the current
part does not hold is marked Earlier part instead of seeking a turn it cannot
reach; and a Bot whose part id is not its id shows one row, not two.

Fixes #3186
Part of #3114
@Birfy Birfy added the agent-pr Pull request opened by an agent label Nov 18, 2026
@Birfy Birfy self-assigned this Nov 18, 2026
@Birfy
Birfy added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 347decd Nov 18, 2026
17 of 19 checks passed
@Birfy
Birfy deleted the dev/3114-history-hit-rows branch November 18, 2026 21:44
@github-actions github-actions Bot removed the agent-pr Pull request opened by an agent label Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[#3114] 历史搜索命中行:Messages 行带 turn、截断提示、同 turn 分行、旧 part 标注、part-id 去重

1 participant