Repository navigation
Give a frozen Bot one human line on share, join and invite (#3114) - #3189
Merged
Merged
Conversation
Written-by: Dev An emergency-stopped Bot answered with the server's own sentence on all three doors. The FRIENDLY table now carries `bot_frozen`, and the share and join-invite mappers hand that code to `mapFaceError`, so sharing, a face-to-face join or invite preview, and accepting an invite say one sentence and keep the `bot_frozen` code. A stop is a state the owner can end, so the room is not treated as ended. Fixes #3188 Part of #3114
Collaborator
Author
|
Verdict: PASS at 34e02b5 Ran at this tip: Red first, and it is real: with the two source files put back to their base blobs and the tests kept, the suite goes 717 / 715 / 2 — What I checked against the spec (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Dev
Fixes #3188
Part of #3114
Owner: Dev
Reviewer: Reviewer
Tier: T3
What changed
An emergency-stopped Bot (Bot Social's
403 bot_frozen) said the server's own sentence on all three doors. The share and join-invite mappers now hand that code tomapFaceError, whoseFRIENDLYtable carries the one sentence for it, so Share with a friend, a face-to-face join or invite preview, and Add friend all say: One of these Bots is emergency-stopped on Bot Social. Its owner can resume it in My Bots on that server, then try again. The error keepscode: bot_frozenand only its.messagechanges;alreadyLeftFacestill answers false, so the room and its grants are kept.plugins/social/src/face-rooms.js:FRIENDLY.bot_frozenafterbot_revoked.plugins/social/src/social.js: one line each inmapShareFriendErrorandmapJoinInviteError.plugins/social/test/face-rooms.test.js,plugins/social/test/social.test.js: the two#3114cases (share, invite, face-room; no raw sentence, no bare code, no tool name; room not ended).docs/subsystems/social.mdandchangelog.d/3114-frozen-bot-one-line.fixed.md.Checkpoint
{"pr":3189,"claim":"Dev","issue":3188,"summary":"An emergency-stopped Bot on Bot Social said the server's own sentence on the share, the face-to-face join/preview and the invite door. FRIENDLY now carries bot_frozen, and the share and join-invite mappers hand that code to mapFaceError, so all three doors say one sentence that names the owner and My Bots. The error keeps code bot_frozen and only its message changes, and alreadyLeftFace still answers false so the room and its grants are kept. Two #3114 tests pin the three doors, the absent raw sentence and the room staying open.","files":["changelog.d/3114-frozen-bot-one-line.fixed.md","docs/subsystems/social.md","plugins/social/src/face-rooms.js","plugins/social/src/social.js","plugins/social/test/face-rooms.test.js","plugins/social/test/social.test.js"],"checks":{"ran":"DSH_HARNESS=/opt/flybot npm --prefix plugins/social run test; TZ=UTC TMPDIR=/data/flybot-tmp npm run verify","result":"green","at":"34e02b5186d0c4051759974c3a76a50322869741"},"next":"none — ready for review"}
Verification at the tip
Ran:
DSH_HARNESS=/opt/flybot npm --prefix plugins/social run test→ 717 / 717 / 0 / 0 at 34e02b5; before the source change the same two cases made it 717 / 715 / 2 (not ok 56,not ok 502).TZ=UTC TMPDIR=/data/flybot-tmp npm run verify→ exit 0: core 3337/3337, social 717/717, tree 149, timeline 172, workflow 524, project 151, plane 20, gate scripts 686, interop 37, live-e2e 34; core lint +arch-docs: OK (6 changed file(s)), plugin lint 0 errors,build-client --check,ds-bot-patches check(10 patches apply;core/equalsds-bot/+ patches; generate no-op).node .github/scripts/changelog.mjs check,testing-layers.mjs --check,check-mojibake.mjs --check→ all pass.Not run:
bot_frozencode for either end of a relationship, so telling "your Bot" from "the friend's Bot" needs two codes or a field on that read-only upstream; not part of this slice, no issue filed there.mapRegisterErrormaps any 401/403 tounauthorized, and a barebot_frozenotherwise lands inCould not register …): not fixed here, per the slice spec.arch-docsran against a base rebuilt from the same tarball tree (this environment has no clone); CI runs it on the real base.