Skip to content

social: the approve-all failure row renders with no CSS rule at all — a role=alert line looks like ordinary dock text - #3193

Open
HugoXK wants to merge 1 commit into
ThinkFlowLab:mainfrom
HugoXK:dev/5-chat-approval-error-style
Open

HugoXK wants to merge 1 commit into
ThinkFlowLab:mainfrom
HugoXK:dev/5-chat-approval-error-style

Conversation

@HugoXK

@HugoXK HugoXK commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #3192

Written-by: Dev-5
Owner: Dev-5
Bot: Dev-5
Tier: T2
Claim-Id: 938ed95e9c6e4295a4a0805f668cbbab
Branch: dev/5-chat-approval-error-style
Base: 9dc8e9fc54b689cb8d05dcbd7b083ca5deb91b9d

What is wrong

The approve-all failure row is drawn as div.fs-chat-error with role="alert". No stylesheet in the repository (or in an installed @deepseek-ai/* package) writes a .fs-chat-error rule — git log -S'.fs-chat-error' -- plugins/social/client.js is empty — so the sentence about a batch whose sends failed renders as ordinary body text: 16 px, normal line height, ink colour, overflow-wrap: normal.

What changes

The row is now drawn as the plugin's own status line in its error tone — className: 'fs-status', data-tone: 'error' — the pattern the rest of this plugin already uses for one-line notices. It keeps role="alert" and its data-flybot="chat-approval-error" hook.

Why reuse instead of writing a .fs-chat-error rule: .fs-status[data-tone=error]{color:#e5484d} already exists and 14 other sites draw notices with it, so a new rule would duplicate the colour literal and the type scale. One source for the error tone, no new colour, no new font size, no new copy.

Measured on the rendered dock (real markup + real CSS, 420×560 viewport):

before after
computed font-size 16 px 12 px
computed line-height normal 17 px
computed colour rgb(20, 20, 20) rgb(229, 72, 77) (#e5484d)
overflow-wrap normal anywhere
row height (8 failing holds, zh window) 59 px 34 px

Red first

On base 9dc8e9fc54b689cb8d05dcbd7b083ca5deb91b9d, with the new case only:

cd plugins/social && TZ=UTC TMPDIR=/tmp node --import ./test/resolve.mjs --test test/approve-all-failure.test.js
not ok 9 - \#3192: the failure row is drawn in the dock's own error tone, not as bare text
  error: 'the row takes the status line, saw "fs-chat-error"'
# tests 9 / # pass 8 / # fail 1

The case also pins the rule it leans on, so it fails if the row loses the tone or the tone rule disappears from the stylesheet: .fs-status{padding:0;font-size:12px;line-height:17px; and .fs-status[data-tone=error]{color:#e5484d}.

Verification at this tip

  • plugins/social/test/approve-all-failure.test.js — # tests 9 / # pass 9 / # fail 0
  • plugins/social/test/social.test.js — # tests 500 / # pass 500 / # fail 0
  • TZ=UTC npm run verify — exit 0; 10 suites, 0 failures in each: 3337 tests, 20, 718, 149, 172, 538, 151, 686, 37, 34; arch-docs: OK (2 changed file(s)); ok 10 patches apply cleanly in order; mojibake scan 0 hits.
  • CI checks at this tip — 21 total: 18 success + 2 skipped + 1 failure; skipped are live · ubuntu · Node 24 · real model and window check, the one failure is enqueue-guard (no Verifier report names the tip b4f5572d…) which is the expected red while the T2 PASS is pending; tests-ok, merge-gate, judge, policy-sign and plugins (social) are success.

Boundaries

Screenshots

Same approval dock, same batch (8 holds, every send fails), Chinese window, 420×560 CSS px at 2x → 840×1120 PNG. Rendered from the real dock markup and the plugin's own stylesheet; only the error row differs between the two.

Before — div.fs-chat-error, 16 px body text, ink colour, row 59 px:

before

After — div.fs-status[data-tone=error], 12 px/17 px, #e5484d, row 34 px:

after

Files live on the evidence/3192 branch (PNG only, no code, no PR of its own) at commit 205844edfe36ad925389b533eb8b1cc197c64435: assets/3192/before.png (72482 bytes) and assets/3192/after.png (70710 bytes); the branch's diff against main is those two paths as Binary files … differ. Content not inspected — this team has no vision model; the load-bearing check is the measured computed style above plus a pixel sample of the row's band (reddish pixels 2 px apart: before 0, after 1058).

Checkpoint

{
  "pr": 3193,
  "claim": "Dev-5",
  "issue": 3192,
  "summary": "The approve-all failure row carried a class no stylesheet ever wrote, so a role=alert sentence about failed sends rendered as ordinary body text. It is now drawn as the plugin's own status line in its error tone (fs-status + data-tone=error), keeping the alert role and the data-flybot hook. Measured on the rendered dock: 16 px ink text becomes 12 px/17 px #e5484d with anywhere wrapping. No new CSS rule, colour, font size or copy; #3158's row cap and code-point cut are untouched.",
  "files": ["plugins/social/client.js", "plugins/social/test/approve-all-failure.test.js", "docs/subsystems/social.md", "changelog.d/3192.fixed.md"],
  "checks": { "ran": "TZ=UTC npm run verify; node --import ./test/resolve.mjs --test test/approve-all-failure.test.js", "result": "green", "at": "b4f5572da24c4d3d8f60a031dc32aff0151179e6" },
  "next": "none — ready for review"
}

…3192)

The batch's one failure line carried a class no stylesheet ever wrote, so a
role="alert" sentence about sends that failed rendered as ordinary body text,
in none of the plugin's own type or colour.

Draw it as the plugin's status line in its error tone (fs-status + data-tone
error), the pattern every other one-line notice here uses; the alert role and
the data-flybot hook stay, and ThinkFlowLab#3158's row cap and code-point cut are untouched.
@HugoXK
HugoXK marked this pull request as ready for review November 19, 2026 00:51
@HugoXK

HugoXK commented Nov 19, 2026

Copy link
Copy Markdown
Contributor Author

@Birfy review request for a T2 verdict at tip b4f5572da24c4d3d8f60a031dc32aff0151179e6.

What this slice changes: the approve-all failure row was drawn as div.fs-chat-error with no CSS rule anywhere (the plugin's injected stylesheet never carried one, and git log -S'.fs-chat-error' on that file is empty), so a failed batch read as ordinary body text. It now draws as the plugin's existing status line in its error tone — fs-status + data-tone=error, using .fs-status[data-tone=error]{color:#e5484d} — and keeps role="alert" plus data-flybot="chat-approval-error".

At this tip: 14 success + 2 skipped + 1 failure; the failure is enqueue-guard saying no Verdict names this tip yet, which is the T2 gate itself. tests-ok, judge, merge-gate, policy-sign and plugins (social) are success.

Red first on base 9dc8e9fc: not ok 9 - #3192: the failure row is drawn in the dock's own error tone, not as bare text, error: 'the row takes the status line, saw "fs-chat-error"'. Green at this tip: approve-all-failure.test.js 9/9, social.test.js 500/500, TZ=UTC npm run verify exit 0.

UI surface: before/after in the body — same dock, same eight failing holds, Chinese window, 420×560 CSS px at 2x (840×1120 PNGs), real dock markup and the plugin's real stylesheet; the only difference is that row, 16 px ink at 59 px before and 12 px/17 px #e5484d at 34 px after.

Boundaries: #3158/#3160's three-row cap, the {count} more not shown tail and the 200-code-point cut are untouched; no new CSS rule, colour, font size or copy; no gate files, .github/**, core/client.js or patches/ds-bot/0008.

@github-actions github-actions Bot added the risk:T2 Risk tier T2 (host/plugin code or an unnamed path), set by the controller from the diff label Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:T2 Risk tier T2 (host/plugin code or an unnamed path), set by the controller from the diff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

social: the approve-all failure row renders with no CSS rule at all — a role=alert line looks like ordinary dock text

1 participant