Repository navigation
Read the Bot tree's sidebar in the window's language (#3114) - #3213
Merged
Merged
Conversation
The Archived Bots group, the row status tags and the reorganization notice drew bare English in a zh window. They now go through tr() with twelve new zh entries, and the three i18n baselines lose the eleven pins that held those draws. Part of #3114 Docs-not-needed: the tree page describes the panel's structure and slots, not the language its copy is drawn in.
Collaborator
Author
|
Verdict: PASS at 0904df4 Ran at this tip: Tier: T2 (plugins/** is in the T2 paths; the repo's risk-gate could not run here — it shells out to gh, absent on this box — so this is the path rule applied to the 15-file list, not a gate run). What I checked at this tip
Not run: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Dev
Fixes #3212
Owner: Dev
Reviewer: Reviewer
Part of #3114
Tier: T2
Checkpoint
{ "pr": 3213, "claim": "Dev", "issue": 3212, "summary": "The Bot tree's sidebar drew the Archived Bots group, each row's status tag and the reorganization notice as bare English in a zh window. The plugin now routes that copy through a local tr() that reads the window translator and keeps today's English, placeholders included, when the host has none. Twelve zh entries join 'Bot tree' in core/src/client/i18n.js, and the three i18n baselines lose the eleven pins that held these draws. #3112 may add the same keys; whichever lands second keeps both blocks and drops its own duplicate.", "files": [ "plugins/tree/client.js", "plugins/tree/test/sidebar-i18n.test.js", "core/src/client/i18n.js", "core/test/i18n-plugins.baseline.json", "core/test/i18n-template-draws.baseline.json", "core/test/i18n-missing-entries.baseline.json", "core/test/i18n-missing-entries.test.js", "changelog.d/3114-tree-sidebar-zh.changed.md", "core/client.js", "patches/ds-bot/0001-core-fixes.patch", "patches/ds-bot/0008-client-bundle.patch" ], "checks": { "ran": "TZ=UTC npm run verify; the tree sidebar i18n test; core i18n five; ds-bot-patches check + canonical", "result": "green", "at": "0904df4fc87e57defae13e77dfa7402a59cef6e2" }, "next": "none — ready for review" }What changed
The Bot tree's sidebar copy that draws by default — the
Archived (N)/Archived botsgroup, the five row status tags (archived,archived · merged into X,retired,idle,outside the tree), the reorganization notice (Tree reorganized,Tree reorganization undone,and N more,Kept: …,Undo,Dismiss) and the right-clickCopy invite link— now goes through atr()added toplugins/tree/client.js. Twelve zh entries were added after'Bot tree'incore/src/client/i18n.js;Dismiss,Copy invite linkandBot treereuse their existing entries. The three i18n baselines lose the eleven English pins for these draws (17/37/155 → 16/34/148; the tree panel's pins 17 → 6).The
tr()here differs from the Social one on purpose: it falls back to the English it was handed and refills the parameters it was given, leaving an unknown placeholder as a placeholder instead of an empty hole.#3112(open, not merged) may add the same twelve keys tocore/src/client/i18n.js: this cut adds them after'Bot tree'(line 221) and#3112adds its block after'Friend requests'(line 199), so the two do not overlap today. If both land, the side that lands second keeps both blocks and drops its own duplicate keys, then re-runsbuild-client.mjs→ds-bot-patches.mjs generate→check→canonical.Docs-not-needed: the tree page describes the panel's structure and slots, not the language its copy is drawn in.
Verification at the tip
Tip SHA: 0904df4
Ran:
cd plugins/tree && TZ=UTC TMPDIR=/data/flybot-tmp DSH_HARNESS=/opt/flybot node --import ./test/resolve.mjs --test test/sidebar-i18n.test.js→ 3/3/0 (red first, with only the test added andplugins/tree/client.jsstill at base: 3/0/3)cd plugins/tree && … --test test/*.test.js→ 152/152/0cd core && node --test test/i18n-plugins.test.js test/i18n-template-draws.test.js test/i18n-missing-entries.test.js test/i18n-plugins-missing-zh.test.js test/i18n.test.js→ 39/39/0cd core && node scripts/build-client.mjs --check→ exit 0node scripts/ds-bot-patches.mjs check→ok ds-bot/ = Fei2411/DeepSeek-Bot@2b10c70,ok 10 patches apply cleanly in order,ok core/ equals ds-bot/ + patches/ds-bot/;canonical→ok patches/ds-bot/ is what generate writesnode .github/scripts/check-mojibake.mjs --check→mojibake: ok — 0 occurrences of U+FFFDnode .github/scripts/changelog.mjs check→changelog: 14 fragment(s) in changelog.d/ are well formedTZ=UTC TMPDIR=/data/flybot-tmp npm run verify→ exit 0 (core 3354/3354, social 686/686, tree 152/152, and the rest green)Not run:
sidebarSection: true) keeps its six draws in the baselines (Bot tree,Copy invite linktitle,Collapse {},Copy invite link for {},Tree,No child bots yet…)#3112's appearance/header/history work is untouched, so the duplicate-key order above is a plan, not a measured merge