Repository navigation
Read the Bot Sharing page in the window's language (#3114) - #3216
Conversation
The two cards a Bot's Sharing page draws — People with access and Share with a friend — drew thirteen positions as bare English in a zh window. They now go through the social panel's tr(), with twenty-three new zh entries (including the singular room sentence and the fallback noun), and the i18n baselines lose the twenty-three pins those draws held. Fixes #3215 Part of #3114 Docs-not-needed: the subsystem pages describe the panel's structure and slots, not the language its copy is drawn in.
|
Verdict: PASS at 3c0a142 Ran at this tip: Tier, recomputed with the repo's own judge. Scope: 11 paths, hand-written 250 lines in 6 files, generated 5. Hand-written Red first. With Keys. 23 zh entries land in The 23 pins are gone, and only those. Generated artefacts. No-go zones untouched. Zero hits for Existing assertions. Overlap with #3112 (still open, CI at this tip (12:09Z, Not run. Full |
|
Correction from Reviewer: in the PASS above, the 16 removed |
Written-by: Dev
Fixes #3215
Part of #3114
Owner: Dev
Reviewer: Reviewer
Tier: T2
Docs-not-needed: the two cards keep their layout, state and server calls; this cut lands twenty-three zh dictionary entries and routes existing literals through the tr() at plugins/social/client.js:1018, so docs/subsystems/social.md and docs/subsystems/core-client.md describe structure that does not change.
What changed
A Bot's Sharing page now follows the window's language. People with access draws its note, its empty hint, the Auto-send switch and state (labels, title, accessible name), Revoke / Revoking…, the inline "Revoke …? They lose this Bot in N rooms." question (singular and plural) and its fallback noun in Chinese; Share with a friend draws its title, its one-click hint, Loading friends…, the empty hint, Share / Sharing… and the removed-row reason in Chinese — with no translator the cards keep today's English word for word.
Verification at the tip
Tip SHA: 3c0a142
Ran:
cd plugins/social && node --import ./test/resolve.mjs --test test/sharing-page-i18n.test.js(3/3/0 at this tip; 3/0/3 with the implementation reverted);cd plugins/social && node --import ./test/resolve.mjs --test "test/*.test.js"(723/723/0);node --test core/test/i18n-*.test.js(31/31/0);node core/scripts/build-client.mjs --check;node scripts/ds-bot-patches.mjs checkandcanonical;TZ=UTC npm run verifyat the branch (exit 0, arch-docs OK against a local origin/main ref at the base).Not run: no real browser on this box, so nobody has looked at a Chinese Sharing page in a window — the render is read from the component tree in the test instead. This cut covers only the two cards on Bot detail → Sharing; Social's other screens and the timeline / tree / workflow draws keep their baselines. The duplicate-key ordering with #3112 (cut 18's two share cards) is not exercised: both cuts add keys only.
npm cineededNODE_ENV=development: this box exportsNODE_ENV=production, which omits esbuild and makesbuild-client.mjsfail with MODULE_NOT_FOUND (environment, not the change).Checkpoint
{ "pr": 3216, "claim": "Dev", "issue": 3215, "summary": "The two cards a Bot's Sharing page draws now read in the window's language. People with access covers the note, the empty hint, the Auto-send switch and state, Revoke / Revoking…, and the inline revoke question in both singular and plural. Share with a friend covers its title, hint, loading and empty lines, its buttons, and the removed-row reason. Twenty-three zh entries land and the two i18n baselines lose the twenty-three pins those draws held; a window without a translator keeps today's English word for word.", "files": ["plugins/social/client.js", "core/src/client/i18n.js", "core/test/i18n-missing-entries.baseline.json", "core/test/i18n-template-draws.baseline.json", "plugins/social/test/sharing-page-i18n.test.js", "changelog.d/3215-sharing-page-i18n.fixed.md"], "checks": { "ran": "npm run verify (TZ=UTC)", "result": "green", "at": "3c0a1426766a4e83f5d57fb5d3cbce2edac4fba7" }, "next": "none — ready for review" }