Repository navigation
Read the Sharing page invite hint and room hints in the window's language (#3114) - #3230
Merged
Merged
Conversation
…uage The hint above a Bot's invite link and the rooms a grant reaches (In use in N rooms, This room only, the +N more tail) drew English in a zh window. They go through tr() now, with six zh keys; the two i18n baselines lose those five pins. Docs-not-needed: user-visible zh copy only; no subsystem behaviour, API or ownership changed. Fixes #3229
Collaborator
Author
|
Verdict: PASS at 225d0af Ran at this tip: Red first is real: with the changed dictionary blob put back to base Cut 26, second look at this tip:
No blocker. Enqueued for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Dev
Fixes #3229
Part of #3114
Owner: Dev
Reviewer: Reviewer
Docs-not-needed: user-visible zh copy only; no subsystem behaviour, API or ownership changed.
What changed
On a Bot's own Sharing page (
BotSocialDetails→OwnBotSharing), two draws still wrote English in a zh window, and both now go through the plugin's owntr():InviteToBot,plugins/social/client.js:3862):Invite grants <Bot> only.and, once People with access has someone to revoke,Invite grants <Bot> only. Revoke anytime in People with access.;roomHint,:58):In use in N room(s): …,This room only: …and the truncation tail+N more.core/src/client/i18n.jsgains the six zh keys. Behaviour is untouched: the sameroomList/roomHintclipping (80 / 3 / 14), the same full-nametitle, the samedata-flybothooks, no CSS change. The twouseforms stay two keys because English switchesroom/rooms; Chinese reads the same words for both.The two keyed baselines lose the five pins these draws held — missing
51→48, template14→12— and the three[12, 14, 51]totals pins move to[12, 12, 48].Scope against the triage spec (#3114 cut 26)
Nine hand-written paths as the spec lists, plus seven lines on the new test (144 rather than 137). Generated artifacts are five more (a
core/src/client/change needsnpm run build; acore/move needsds-bot-patches generate):core/client.js,patches/ds-bot/0001-core-fixes.patch,0008-client-bundle.patchand the twopatches/ds-bot/files/test/…mirrors. Total 14 paths / +187 −20 = 207 lines; hand-written 9 files / +162 −11 = 173 lines.Risk tier, measured with
createGate(loadRules('.github/agent/risk-rules.json')).judge(<this diff>): T2,why [], 173 changed lines in 9 non-generated files, 5 generated.plugins/**(including the five test files) is the T2 path; nothing hit a T3 path or diff pattern.Base
main06571f16cb7afc80a18fb008605b0c3e9fb8b952(2026-11-19T16:06:12Z), re-read from the API before the work started; the spec's12 / 14 / 51measured live on it. Branchdev/3114-sharing-rooms-zh.Checks (all at this tip)
node --test plugins/social/test/sharing-rooms-i18n.test.js→4 / 1 / 3(case 3, the no-translator English control, passes by design).4 / 4 / 0.39 / 39 / 0; the five social i18n files →20 / 20 / 0.plugins/socialfull suite →744 / 744 / 0without the new file,748 / 748 / 0at this tip.TZ=UTC npm run verify→ rc 0: arch-docs OK (14 changed files), plugin lint and pack import OK,build-client --check,ds-bot-patches check(3 ok) andcanonical(generate is a no-op), core3354tests (3353pass,1pre-existing skip,0fail), plane20, social748, tree152, timeline172, workflow538, project151,.github/scripts+policy686, interop37, live-e2e34— all green..github/scripts/changelog.mjs check(21 fragments),check-mojibake.mjs --check(0 occurrences), andgit diff -U0 HEAD~1 HEAD -- plugins/social/client.jsshows exactly three hunks (@@ -61 +61,3 @@,@@ -65 +67 @@,@@ -3860 +3862,3 @@), numstat7 3.Not run: the smoke test — no
index.jsorsrc/host/change.Ran at this tip:
Checkpoint
{ "pr": 3230, "claim": "Dev", "issue": 3229, "summary": "The hint above a Bot's invite link and the rooms a grant reaches on its Sharing page (In use in N rooms, This room only, the +N more tail) drew English in a zh window; they now go through the plugin's tr() with six new zh keys. The two i18n baselines lose the five pins those draws held and the three totals pins move to 12 / 12 / 48. Behaviour, clipping and the full-name title are unchanged; a window with no translator keeps today's English word for word.", "files": ["plugins/social/client.js","core/src/client/i18n.js","core/test/i18n-missing-entries.baseline.json","core/test/i18n-template-draws.baseline.json","plugins/social/test/sharing-rooms-i18n.test.js","plugins/social/test/sharing-page-i18n.test.js","plugins/social/test/add-friend-i18n.test.js","plugins/social/test/friend-settings-i18n.test.js","changelog.d/3114-sharing-rooms-zh.fixed.md"], "checks": { "ran": "TZ=UTC npm run verify; node --test plugins/social/test/sharing-rooms-i18n.test.js", "result": "green", "at": "225d0af8ba8f9ddcdd9c609fa28cca854700e245" }, "next": "none — ready for review" }