Skip to content

[bug] nightly: node version layout check reads the preview before its image is available #393

Closed

Description

@hsliuustc0106

Evidence

  • Nightly #12, browser-extended step 8, main 4360d9eb66b23598d3f637b2288745291e818862, scheduled attempt 1. Ubuntu 22.04, Node 24.22.1, Python 3.12.16, Playwright Core 1.58.2 / Chromium headless shell; isolated fixture, no live model provider.
  • tests/browser/node_versions.mjs exits on locator.evaluate: TypeError: Failed to execute 'getComputedStyle' on 'Window': parameter 1 is not of type 'Element'. at layout evaluation.

Reproduce

At the run revision, use the nightly dev/fixture setup and run node tests/browser/node_versions.mjs. The script opens the fixture target's two-entry history, waits for a prompt, then measures the first history detail panel. This was observed in the linked nightly; not independently rerun.

Expected / actual

  • Expected: after the first image preview is ready, verify the compact side-by-side layout and image fit, or report a specific missing-media failure.
  • Actual: the prompt and detail layout can be present while the selected detail contains no img. The test passes the lookup directly to getComputedStyle and throws before asserting layout.

Diagnosis / acceptance

The immediate test failure is a missing guard/wait for the first history entry's image. VersionMedia fetches the image URL asynchronously and has distinct loading and missing-media states. The log does not show which state caused the absent image, so this does not establish an end-user thumbnail bug. Pin the test to the expected entry and wait for its image with a bounded, descriptive failure; when the image is absent record the media state/response instead of throwing a null-element TypeError. Keep the layout assertions and show the same fixture passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:ciContinuous integration and checks

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions