Repository navigation
Conversation
…hinkFlowLab#119) Reading mode hid the whole reference strip, so saved canvas connections could not be inspected or removed. Keep those references visible, say clearly that they are not sent to the speech model, and leave music and first-last behaviour unchanged.
|
The functional change looks right, and the current blocker is CI rather than this PR's source. 1. The failing check is in a file this PR does not touch. 2. Reading mode still offers an "add reference" entry. 3. The extraction into |
…hinkFlowLab#119) Reading mode only shows the reference strip when connections already exist. Unsupported kinds keep their kind-specific errors instead of the unused-in-reading copy.
Summary
The audio generation panel hid the entire reference manager whenever the node was in text-to-speech (reading) mode. Canvas connections to a speech node were still saved, but the panel showed no thumbnails and no remove control, so the saved relationship could not be checked or edited there.
composerReferenceVisibilitykeeps the strip visible in reading mode when connections already exist, with a bilingual note that these references are not sent to the speech model. The empty “add reference” control is hidden in reading mode, so the panel does not invite a new connection while saying those references are unused. The existing@mention control stays hidden in reading and music modes. Music models that accept an audio reference, and first-last video frame slots, are unchanged. Removing a thumbnail still updates the project references and canvas edges.Reading-mode copy is used only when the reference kind itself is valid for the model or catalog path. A video or other unsupported kind on a TTS node reports the specific kind error (
errors.rules.kindReference/generation.issue.unsupportedKind, or the existing video-reference rule) instead of “this mode does not use this reference”. An allowed kind in reading mode still gets the unused-in-reading message, andbackendReferences/generationActiveReferencesstill exclude those inputs.Review follow-up
Addresses the review on 2026-11-17 (Asia/Shanghai) by Probiotics5333:
origin/main(58b6a96d) into this branch with a regular merge (no force-push) so CI can re-run against latest main. The earlierbrowser (voice)failure was intests/browser/voice_library.mjs, which this PR does not touch.Linked issue
Fixes #119Labels
type:bug,area:canvas,modality:audio,area:i18n); this account could not apply them when opening the PRTest plan
Local (tip
3b0bc4d1, mergedorigin/main58b6a96d, Asia/Shanghai)Python / pre-commit were not re-run for this follow-up: the change is TypeScript UI and rule-message selection only. Full pytest was previously green on the original tip after fixing a stale editable install; this follow-up does not touch Python.
Browser verification, isolated fixture only (no user project, no paid generation):
The isolated fixture had no preconfigured speech service, so this run used local TTS (
audioMode: "tts"), which takes the samereadingUI path as a configured service speech model. After removing the last reference, the strip and context note are gone and the empty “添加参考素材” control stays hidden.Left to CI
browser (voice)after the merge of current main, and the isolated browser lane that runstests/browser/tts_reading_references.mjs.Evidence that it works
tts_reading_references.mjs, zh-CN, headless). No screenshots were attached. A reviewer can repeat that script against the isolated fixture, or open a TTS audio node that already has a canvas image connection and confirm the strip, note, and remove control, without submitting to a paid provider.Provider verification
No live or paid provider calls were made. The browser run did not submit a generation job.
Bilingual UI
No new strings in this follow-up. Existing
generation.reference.readingContextandgeneration.issue.audioModeReference/ kind-error strings are reused.