Repository navigation
[feat] canvas: open model settings from an empty model selector - #398
Open
Maurokrekels wants to merge 1 commit into
Open
Maurokrekels wants to merge 1 commit into
Maurokrekels wants to merge 1 commit into
Conversation
Maurokrekels
requested review from
hsliuustc0106 and
princepride
as code owners
November 18, 2026 10:36
When no generation model is configured for the selected node type, the composer showed a disabled selector with no way forward. It now shows a Configure image/video/audio model button that opens Settings on that model category. The composer stays mounted, so the prompt, references and parameters are kept, and nothing is submitted. Refs ThinkFlowLab#370
Maurokrekels
force-pushed
the
feat/composer-configure-model-action
branch
from
November 19, 2026 09:32
a94b071 to
d5f4c57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NodeComposerwas a disabled placeholder with no way forward. It now shows a "Configure video model" button (or image, or audio) in its place.ModelSettingscategory state through a newinitialModelKindprop, so there is no new settings page.modelSetup.videoAction,modelSetup.imageActionandmodelSetup.audioActionentries are used, so bothzh-CNanden-USare covered.Linked issue
Refs #370. I used
Refsbecause I did not verify the "save a model and it becomes selectable" and focus-restoration criteria (see below).Fixes #NorRefs #Nis included, or no issue appliesLabels
Suggested:
type:feat,area:canvas,area:i18n. I cannot set labels myself.Test plan
npx tsc --noEmitnpm run check:i18n(0 problems)npm test(838 pass)tests/browser/composer_configure_model.mjsagainst the isolated fixture API and Vite, with system Chrome. It passes with this change and fails onmain(the button is not found). It checks that the action is absent for image (an image model exists in the fixture), present for video, opens by keyboard, lands on the Video category, keeps the prompt after closing the dialog, and makes no generation request.provider_settings.mjs.Evidence that it works
The "before" state is in the screenshot of the issue.
Composer with the new button:
Settings opened on the Video category:
Provider verification
No provider calls were made. Everything ran against the isolated fixture API. The fixture has a segmentation service listed under Video, so the screenshot shows one service there; with a truly empty category the dialog shows its existing empty state with an "Add service" button.
Bilingual UI
No user-facing strings were added; the existing bilingual
modelSetup.*Actionentries are reused. I checked the button inen-US(screenshot) andzh-CN(the browser test).Not verified
SearchableSelectchanged because it is now in a conditional, so?w=1gives a much smaller diff.