Repository navigation
Conversation
The workspace autosaves while the suite reads a snapshot to build expectedVersions, so a save that lands between the read and the command makes the server reject it as revision_conflict. That is the documented reload-and-retry contract, so the suite now waits for the save indicator, re-reads the revisions and retries up to three times instead of failing on a stale snapshot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tests/browser/created_node_focus.mjsoccasionally failed on CI at thehistory.undothat followscanvas.hide:The suite was not failing on a history bug. It reads a project snapshot to build
expectedVersions, then posts the command. The workspace autosaves on its own (creationProjection.ts,creationEditorSession.ts:106), so a save landing between that read and the command bumps a revision, and the server correctly rejects the command withstatus: "rejected"/issues[0].code = "revision_conflict"(HTTP 200, "This item changed since it was loaded. Reload it and try again.").Fix
send()now waits for the "Saved on this device" indicator, re-reads the revisions, and retries up to three times when the receipt is arevision_conflict. Any other rejection, or three consecutive conflicts, still fails the suite.Verification
history.undowithrevision - 1returnsrejected+revision_conflict; re-reading and re-posting returnsapplied.