Repository navigation
[test] canvas: wait for history preview before checking layout - #408
Merged
wangtiance merged 1 commit intoNov 19, 2026
Merged
Conversation
## summary - Wait for the expected asset image to load before measuring history. - Report asset identity, thumbnail responses and media state on failure. - Add delayed and missing-thumbnail probes and bilingual run guidance. Fixes: ThinkFlowLab#393
wangtiance
requested review from
hsliuustc0106 and
princepride
as code owners
November 19, 2026 11:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The node-history browser journey measured image styling after the prompt appeared, while the asynchronous thumbnail could still be absent. It then passed null to getComputedStyle and failed before checking layout.
Locate the detail panel by the expected generated asset ID and wait for its image to be visible, complete and have nonzero natural dimensions before preserving the existing layout/cover assertions. On failure report the asset ID, thumbnail responses, media text and image state. Add optional delayed/missing-thumbnail probes and document their use in Chinese and English. No production UI behavior changes.
Linked issue
Fixes #393
Labels
Test plan
Local Windows / Chrome 157 / Node 26.13.0, isolated creation API + Vite:
Left to CI: Release checks and Ubuntu 22.04 extended browser lane. Full Python/frontend unit suites and a production build were not run for this test/docs-only change.
Evidence that it works
N/A for product screenshots: test and validation-documentation changes only. The full delayed journey retained the existing compact layout, cover preview, frozen references, apply/reload and real MP4/WAV checks. Missing media now yields a specific diagnostic instead of a null-element TypeError. This change does not establish or fix an end-user thumbnail service defect.
Provider verification
No live model calls. The journey uses isolated model fixtures and real file, preview, project persistence and browser operations.
Bilingual UI
No user-facing UI strings changed. Fault-probe instructions are included in both Chinese and English.
Only #393 is in scope; no #401 benchmark artifacts, storage code or threshold changes are included.