Repository navigation
test(execution): run the host probe test on its own stubs only - #219
Merged
Merged
Conversation
The test put /usr/bin and /bin on the probe's PATH, so the machine's own podman ran inside it and could exceed the probe's 12 s timeout. Its PATH now holds the stub docker and links to sh, sed, grep and hostname.
harenome
force-pushed
the
fix/hosts-probe-path
branch
from
November 19, 2026 10:33
faf19c1 to
d150365
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #216
What
test_the_probe_says_when_the_host_s_docker_has_userns_remapranhosts.PROBEwith/usr/bin:/binafter its stubdockeronPATH. The probe runs$c psfor eachdockerandpodmanit finds, so apodmaninstalled on the machine ran inside the test. A slow one exceeded the probe's 12 s timeout. The test'sPATHis now one temporary directory. It holds the stubdockerand links tosh,sed,grepandhostname, found withshutil.which. Each subtest also checks that the probe finds nopodman,uvorharbor.Touches
backend (tests only)
app/tests/test_hosts.pyVerified
In a rootless Podman container (
python:3.12,--init), with/usr/bin/podmanset to#!/bin/shandsleep 20:subprocess.TimeoutExpired: ... timed out after 12.0 seconds(24 s).In a new container of the same kind:
python3 app/tests/parallel.py: 2250 tests, OK.python3 app/tests/parallel.py app/ui_tests: 639 tests, OK.Risk
Low. Only the test changes. On a machine without
hostnameor one of the other three tools,shutil.whichreturnsNoneand the test fails at setup with aTypeErrorinstead of running the probe. A revert undoes it.