Skip to content

test(execution): run the host probe test on its own stubs only - #219

Merged
harenome merged 1 commit into
ThinkFlowLab:mainfrom
harenome:fix/hosts-probe-path
Nov 19, 2026
Merged

harenome merged 1 commit into
ThinkFlowLab:mainfrom
harenome:fix/hosts-probe-path

Conversation

@harenome

Copy link
Copy Markdown
Collaborator

Closes #216

What

test_the_probe_says_when_the_host_s_docker_has_userns_remap ran hosts.PROBE with /usr/bin:/bin after its stub docker on PATH. The probe runs $c ps for each docker and podman it finds, so a podman installed on the machine ran inside the test. A slow one exceeded the probe's 12 s timeout. The test's PATH is now one temporary directory. It holds the stub docker and links to sh, sed, grep and hostname, found with shutil.which. Each subtest also checks that the probe finds no podman, uv or harbor.

Touches

backend (tests only)

  • app/tests/test_hosts.py

Verified

In a rootless Podman container (python:3.12, --init), with /usr/bin/podman set to #!/bin/sh and sleep 20:

  • On main (db6e8f9), the test fails in both subtests with subprocess.TimeoutExpired: ... timed out after 12.0 seconds (24 s).
  • On this branch, the test passes in 6 ms.

In a new container of the same kind:

  • The backend suite, python3 app/tests/parallel.py: 2250 tests, OK.
  • The route suite, python3 app/tests/parallel.py app/ui_tests: 639 tests, OK.

Risk

Low. Only the test changes. On a machine without hostname or one of the other three tools, shutil.which returns None and the test fails at setup with a TypeError instead of running the probe. A revert undoes it.

The test put /usr/bin and /bin on the probe's PATH, so the machine's own podman ran inside it and could exceed the probe's 12 s timeout. Its PATH now holds the stub docker and links to sh, sed, grep and hostname.
@harenome
harenome force-pushed the fix/hosts-probe-path branch from faf19c1 to d150365 Compare November 19, 2026 10:33
@harenome
harenome merged commit f094cba into ThinkFlowLab:main Nov 19, 2026
2 checks passed
@harenome
harenome deleted the fix/hosts-probe-path branch November 19, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests: the host probe test runs the machine's own podman and times out

1 participant