Repository navigation
ci(ci): skip the tests workflow on draft pull requests - #234
Merged
Merged
Conversation
Run it again when a draft is marked ready, and keep the manual trigger. The PR judge already skips drafts.
This comment has been minimized.
This comment has been minimized.
🔴 PR judge · 5 of 7 yes · #234 ↔ #233
Acceptance criteria, 4 of 4 met
Checks the script runs itself, 4 of 4 pass
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #233
What
The
testsworkflow skips draft pull requests. It runs again when a draft is marked ready for review, and still runs by hand. This matches what the PR judge already does.Touches
.github/workflows/tests.yml: addsready_for_reviewto thepull_requesttypes, and the job conditiongithub.event_name != 'pull_request' || !github.event.pull_request.draftAGENTS.md: the CI paragraph is now one line per workflow, saying what each runs and when (drafts skipped)Verified
testsshould run on it.testsshould show as skipped, then run when marked ready.Risk
testsis a required check, a skipped job counts as passing. A draft can't be merged anyway, and marking it ready runs the real job.