Repository navigation
fix(standard): redact the prepare record and report a failed prepare action - #236
Open
pierreleca wants to merge 6 commits into
Open
pierreleca wants to merge 6 commits into
pierreleca wants to merge 6 commits into
Conversation
… reference The kit's own proof, taken again once the reference for late finds the button in the observation it is given: the nine units' ids, the same twice and unique; no reference found in the unit's prompt (9 of 9); the null control passing 0 of 9 checks and the reference 9 of 9. Besides the two control jobs' names, the leak check's counts follow the references this run drew: 2 looked for and 7 too short, against 1 and 8 before.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #235
What
Three repairs to what #224 added to
agent.computer/v1. The prepare record now goes through the repository's redaction, as the relay's records do: a credential-shaped value in an action or a file name is written as[REDACTED]. Aprepareaction that fails now answers with an error that names it, and the actions after it are not run. Onmainthe call answers as a success and goes on. The kit'slatereference now finds the button in the observation it is sent, and its test fails on blank pictures. The port's page states both changes ofprepare, and the kit's words say thatlatedoes not bound the number of presses. The kit's controls are recorded again, on the desktop thatmainbuilds since #220 (Pillow 13.0.0). The kit stays at version 2.Touches
backend (the standard: the port's server) · catalogue (the kit's reference, its words and its record) · docs and site (the port's page).
Verified
mainin the sandbox used here.proveon the kit, on a desktop image that holds Pillow 13.0.0: the null control 0 of 9, the reference 9 of 9, a control that clicks without looking failslate.prepare: 18preparecalls on the kit's nine units, none in error, the same calls as before the change. It ran on the same port and kit code, before this branch moved onto today'smain.Risk
An agent whose
prepareaction failed unseen now gets an error before its task. An action that looks like a credential is recorded as[REDACTED]; the desktop still receives it unchanged. Two limits are kept: a failed action's error holds the desktop's whole error output, and a step's action that raises is still no error. Undone by a revert: no stored data changes and nothing migrates.