Repository navigation
Routing: align the letter tile of an upstream without a logo - #366
Merged
Merged
Conversation
The letter tile drawn for an upstream without a known logo was a span holding text, so its baseline was the letter's baseline. In the route table's rule list, where logos sit inline with vertical-align: -2px, the tile dropped about 5 px below the text, and the inline-block there also dropped its flex centring, pushing the letter to the corner. Draw the tile as an SVG like the other logos, so it lines up wherever they do. Fixes #365 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #365.
An upstream without a known logo gets a letter tile. The tile was a
spanholding the letter, so its baseline was the letter's baseline. In the route table's rule list, logos sit inline withvertical-align: -2px(tuned for SVG logos, whose baseline is their bottom edge), so the tile sat about 5 px below the text; theinline-blockthere also replaced itsinline-flex, pushing the letter off centre.The tile is now an SVG (rounded 1 px outline at 35 % and the centred letter), so it lines up wherever the other logos do.
Checked in the preview harness with an upstream renamed to have no logo: the tile's centre moved from 5.5 px below the text's centre to 0.5 px, the same as the other logos in the list.
🤖 Generated with Claude Code