Repository navigation
fix: isolate recorder files in verified private runtime jobs - #64
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recorder files previously used predictable names derived from
USERunder an insufficiently verified runtime path. A writable or substituted directory could redirect file access or overwrite unrelated files.This change verifies absolute runtime paths component by component, rejects symlinks and unsafe ownership/permissions, and creates unique private recording jobs. Files are created exclusively as 0600 through pinned directory descriptors; parec writes through an inherited WAV descriptor. PIDFD identity binding and the startup gate are preserved.
Successful WAVs remain available through transcription, including when the recorder is discarded, reused, or destroyed. The transcription worker removes the completed job in its finally block; aborted and failed jobs are cleaned separately.
Validation:
/proc/self/fd/Nin an isolated file test; no productive audio services were changed.GitHub validation on commit
2bd940e:TTS, Wayland detection, unrelated alerts, versions, tags, and releases are out of scope. The private-directory boundary protects against other UIDs; same-UID/root processes remain outside that boundary. Abrupt application or host termination can leave private recording jobs; this fix adds no global sweeper.